From: Gabriel Goller <g.goller@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH network] sdn: remove unused function get_uplink_iface
Date: Mon, 15 Sep 2025 11:51:52 +0200 [thread overview]
Message-ID: <20250915095154.78769-1-g.goller@proxmox.com> (raw)
Ripgrepped over all my local repos and didn't find an invocation. The
last invocation was removed with:
938ebef7bd73 ("vlan/qinq: use bridge option instead uplink-id").
Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
src/PVE/Network/SDN/Zones/Plugin.pm | 25 -------------------------
1 file changed, 25 deletions(-)
diff --git a/src/PVE/Network/SDN/Zones/Plugin.pm b/src/PVE/Network/SDN/Zones/Plugin.pm
index 0a977fd35a13..6dc2f655ffce 100644
--- a/src/PVE/Network/SDN/Zones/Plugin.pm
+++ b/src/PVE/Network/SDN/Zones/Plugin.pm
@@ -277,31 +277,6 @@ sub del_bridge_fdb {
#helper
-sub get_uplink_iface {
- my ($interfaces_config, $uplink) = @_;
-
- my $iface = undef;
- foreach my $id (keys %{ $interfaces_config->{ifaces} }) {
- my $interface = $interfaces_config->{ifaces}->{$id};
- if (my $iface_uplink = $interface->{'uplink-id'}) {
- next if $iface_uplink ne $uplink;
- if ($interface->{type} ne 'eth' && $interface->{type} ne 'bond') {
- warn "uplink $uplink is not a physical or bond interface";
- next;
- }
- $iface = $id;
- }
- }
-
- #create a dummy uplink interface if no uplink found
- if (!$iface) {
- warn "can't find uplink $uplink in physical interface";
- $iface = "uplink${uplink}";
- }
-
- return $iface;
-}
-
sub get_local_route_ip {
my ($targetip) = @_;
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-09-15 9:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 9:51 Gabriel Goller [this message]
2025-09-16 10:10 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250915095154.78769-1-g.goller@proxmox.com \
--to=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox