public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox{-ve-rs, -firewall} 0/3] Add support for legacy ipset / alias names
Date: Fri, 12 Sep 2025 18:11:15 +0200	[thread overview]
Message-ID: <20250912161121.229819-1-s.hanreich@proxmox.com> (raw)

The introduction of scopes to alias / ipset names in firewall rules in Proxmox
VE 8 did not include any automated mechanism for converting firewall rules. Many
users still have firewall configurations containing unscoped names. The initial
decision to only support the new format with proxmox-firewall led to problems
with users trying to migrate to the nftables firewall, since the daemon fails to
parse the configuration and generates no nftables ruleset at all.

proxmox-ve-rs:

Stefan Hanreich (2):
  config: firewall: add support for legacy alias names
  config: firewall: add support for legacy ipset names

 proxmox-ve-config/src/firewall/cluster.rs     |  16 ++-
 proxmox-ve-config/src/firewall/common.rs      |   4 +
 proxmox-ve-config/src/firewall/guest.rs       |  10 +-
 proxmox-ve-config/src/firewall/types/alias.rs |  98 ++++++++++++++++-
 proxmox-ve-config/src/firewall/types/ipset.rs | 104 +++++++++++++++++-
 proxmox-ve-config/src/firewall/types/rule.rs  |  14 ++-
 .../src/firewall/types/rule_match.rs          |  14 +--
 7 files changed, 232 insertions(+), 28 deletions(-)


proxmox-firewall:

Stefan Hanreich (1):
  fix #6107: add support for legacy ipset / alias names

 proxmox-firewall/src/config.rs                |  93 ++++++++--
 proxmox-firewall/src/firewall.rs              |  15 +-
 proxmox-firewall/src/object.rs                |   4 +-
 proxmox-firewall/src/rule.rs                  |  28 ++-
 proxmox-firewall/tests/input/cluster.fw       |   2 +
 .../integration_tests__firewall.snap          | 172 ++++++++++++++++++
 6 files changed, 276 insertions(+), 38 deletions(-)


Summary over all repositories:
  13 files changed, 508 insertions(+), 66 deletions(-)

-- 
Generated by git-murpp 0.8.0

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


             reply	other threads:[~2025-09-12 16:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-12 16:11 Stefan Hanreich [this message]
2025-09-12 16:11 ` [pve-devel] [PATCH proxmox-ve-rs 1/2] config: firewall: add support for legacy " Stefan Hanreich
2025-09-12 16:11 ` [pve-devel] [PATCH proxmox-ve-rs 2/2] config: firewall: add support for legacy ipset names Stefan Hanreich
2025-09-12 16:11 ` [pve-devel] [PATCH proxmox-firewall 1/1] fix #6107: add support for legacy ipset / alias names Stefan Hanreich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250912161121.229819-1-s.hanreich@proxmox.com \
    --to=s.hanreich@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal