From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox-offline-mirror 6/8] wizard: drop Release::Buster and Ceph::Luminous/Nautilus
Date: Mon, 8 Sep 2025 15:16:47 +0200 [thread overview]
Message-ID: <20250908131658.650928-7-f.gruenbichler@proxmox.com> (raw)
In-Reply-To: <20250908131658.650928-1-f.gruenbichler@proxmox.com>
not supported anymore, and the referenced key file does not exist anymore on a
Trixie-based system..
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
src/bin/proxmox-offline-mirror.rs | 55 +++++++++----------------------
1 file changed, 15 insertions(+), 40 deletions(-)
diff --git a/src/bin/proxmox-offline-mirror.rs b/src/bin/proxmox-offline-mirror.rs
index c444e6d..b14e680 100644
--- a/src/bin/proxmox-offline-mirror.rs
+++ b/src/bin/proxmox-offline-mirror.rs
@@ -50,7 +50,6 @@ enum Release {
Trixie = 13,
Bookworm = 12,
Bullseye = 11,
- Buster = 10,
}
impl Display for Release {
@@ -59,7 +58,6 @@ impl Display for Release {
Release::Trixie => write!(f, "trixie"),
Release::Bookworm => write!(f, "bookworm"),
Release::Bullseye => write!(f, "bullseye"),
- Release::Buster => write!(f, "buster"),
}
}
}
@@ -138,26 +136,21 @@ fn derive_debian_repo(
skip_packages,
skip_sections,
};
- let url = if *release == Release::Buster && *variant == DebianVariant::Security {
- // non-standard security repo
- "http://deb.debian.org/debian-security buster/updates".to_string()
- } else {
- match variant {
- DebianVariant::Main => {
- format!("http://deb.debian.org/debian {release}")
- }
- DebianVariant::Security => {
- format!("http://deb.debian.org/debian-security {release}-security")
- }
- DebianVariant::Updates => {
- format!("http://deb.debian.org/debian {release}-updates")
- }
- DebianVariant::Backports => {
- format!("http://deb.debian.org/debian {release}-backports")
- }
- DebianVariant::Debug => {
- format!("http://deb.debian.org/debian-debug {release}-debug")
- }
+ let url = match variant {
+ DebianVariant::Main => {
+ format!("http://deb.debian.org/debian {release}")
+ }
+ DebianVariant::Security => {
+ format!("http://deb.debian.org/debian-security {release}-security")
+ }
+ DebianVariant::Updates => {
+ format!("http://deb.debian.org/debian {release}-updates")
+ }
+ DebianVariant::Backports => {
+ format!("http://deb.debian.org/debian {release}-backports")
+ }
+ DebianVariant::Debug => {
+ format!("http://deb.debian.org/debian-debug {release}-debug")
}
};
@@ -183,10 +176,6 @@ fn derive_debian_repo(
"/usr/share/keyrings/debian-archive-bullseye-security-automatic.pgp"
}
(Release::Bullseye, _) => "/usr/share/keyrings/debian-archive-bullseye-automatic.pgp",
- (Release::Buster, DebianVariant::Security) => {
- "/usr/share/keyrings/debian-archive-buster-security-automatic.gpg"
- }
- (Release::Buster, _) => "/usr/share/keyrings/debian-archive-buster-stable.gpg",
};
let suggested_id = format!("debian_{release}_{variant}");
@@ -215,7 +204,6 @@ fn action_add_mirror(config: &SectionConfigData) -> Result<Vec<MirrorConfig>, Er
(Release::Trixie, "Trixie"),
(Release::Bookworm, "Bookworm"),
(Release::Bullseye, "Bullseye"),
- (Release::Buster, "Buster"),
];
let release = read_selection_from_tty("Select release", releases, Some(0))?;
@@ -247,8 +235,6 @@ fn action_add_mirror(config: &SectionConfigData) -> Result<Vec<MirrorConfig>, Er
}
Distro::PveCeph => {
enum CephRelease {
- Luminous,
- Nautilus,
Octopus,
Pacific,
Quincy,
@@ -270,13 +256,6 @@ fn action_add_mirror(config: &SectionConfigData) -> Result<Vec<MirrorConfig>, Er
(CephRelease::Quincy, "Quincy (17.x)"),
]
}
- Release::Buster => {
- vec![
- (CephRelease::Luminous, "Luminous (12.x)"),
- (CephRelease::Nautilus, "Nautilus (14.x)"),
- (CephRelease::Octopus, "Octopus (15.x)"),
- ]
- }
};
let ceph_release = read_selection_from_tty(
@@ -327,12 +306,9 @@ fn action_add_mirror(config: &SectionConfigData) -> Result<Vec<MirrorConfig>, Er
Release::Trixie => "/usr/share/keyrings/proxmox-release-trixie.gpg",
Release::Bookworm => "/usr/share/keyrings/proxmox-release-bookworm.gpg",
Release::Bullseye => "/etc/apt/trusted.gpg.d/proxmox-release-bullseye.gpg",
- Release::Buster => "/etc/apt/trusted.gpg.d/proxmox-release-buster.gpg",
};
let ceph_release = match ceph_release {
- CephRelease::Luminous => "luminous",
- CephRelease::Nautilus => "nautilus",
CephRelease::Octopus => "octopus",
CephRelease::Pacific => "pacific",
CephRelease::Quincy => "quincy",
@@ -387,7 +363,6 @@ fn action_add_mirror(config: &SectionConfigData) -> Result<Vec<MirrorConfig>, Er
Release::Trixie => "/usr/share/keyrings/proxmox-release-trixie.gpg",
Release::Bookworm => "/usr/share/keyrings/proxmox-release-bookworm.gpg",
Release::Bullseye => "/etc/apt/trusted.gpg.d/proxmox-release-bullseye.gpg",
- Release::Buster => "/etc/apt/trusted.gpg.d/proxmox-release-buster.gpg",
};
let suggested_id = format!("{product}_{release}_{variant}");
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-09-08 13:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 13:16 [pve-devel] [PATCH proxmox-offline-mirror 0/8] misc. wizard cleanup Fabian Grünbichler
2025-09-08 13:16 ` [pve-devel] [PATCH proxmox-offline-mirror 1/8] wizard: simplify repository url generation Fabian Grünbichler
2025-09-08 13:16 ` [pve-devel] [PATCH proxmox-offline-mirror 2/8] wizard: implement PartialOrd/Ord on Release Fabian Grünbichler
2025-09-08 13:16 ` [pve-devel] [PATCH proxmox-offline-mirror 3/8] wizard: switch to .pgp for Debian keyring files Fabian Grünbichler
2025-09-08 13:53 ` Shannon Sterz
2025-09-09 8:24 ` Fabian Grünbichler
2025-09-08 13:16 ` [pve-devel] [PATCH proxmox-offline-mirror 4/8] wizard: use /usr/share/keyring/proxmox-release-bookworm.gpg Fabian Grünbichler
2025-09-08 13:16 ` [pve-devel] [PATCH proxmox-offline-mirror 5/8] wizard: simplify Proxmox repository url generation Fabian Grünbichler
2025-09-08 15:20 ` Shannon Sterz
2025-09-09 8:35 ` Fabian Grünbichler
2025-09-08 13:16 ` Fabian Grünbichler [this message]
2025-09-08 13:16 ` [pve-devel] [PATCH proxmox-offline-mirror 7/8] wizard: simplify default Debian components Fabian Grünbichler
2025-09-08 13:16 ` [pve-devel] [PATCH proxmox-offline-mirror 8/8] wizard: deduplicate Proxmox key path mapping Fabian Grünbichler
2025-09-08 15:27 ` [pve-devel] [PATCH proxmox-offline-mirror 0/8] misc. wizard cleanup Shannon Sterz
2025-09-09 9:02 ` [pve-devel] applied-series: " Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250908131658.650928-7-f.gruenbichler@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox