From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Lukas Wagner <l.wagner@proxmox.com>
Subject: [pve-devel] [PATCH manager] api: apt: Return valid utf8 on changelog
Date: Tue, 2 Sep 2025 16:53:44 +0200 [thread overview]
Message-ID: <20250902145345.500823-1-m.sandoval@proxmox.com> (raw)
This was displayed wrongly on the web UI and when calling
pvesh get /nodes/localhost/apt/changelog
One potential example of such a package was bind9-dnsutils where the
character `ř` was rendered as `Å`.
Reported-by: Lukas Wagner <l.wagner@proxmox.com>
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
PVE/API2/APT.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/PVE/API2/APT.pm b/PVE/API2/APT.pm
index bd651ba1..4de4cb5b 100644
--- a/PVE/API2/APT.pm
+++ b/PVE/API2/APT.pm
@@ -7,6 +7,7 @@ use POSIX;
use File::stat ();
use IO::File;
use File::Basename;
+use Encode qw(decode);
use LWP::UserAgent;
@@ -418,7 +419,7 @@ __PACKAGE__->register_method({
timeout => 10,
logfunc => sub {
my $line = shift;
- $output .= "$line\n";
+ $output .= decode('UTF-8', $line) . "\n";
},
noerr => 1,
);
--
2.47.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-09-02 14:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 14:53 Maximiliano Sandoval [this message]
2025-09-02 15:06 ` Daniel Kral
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250902145345.500823-1-m.sandoval@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox