From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server v2 2/6] block job: mirror: follow guest-fsfreeze setting
Date: Tue, 2 Sep 2025 14:45:17 +0200 [thread overview]
Message-ID: <20250902124524.368080-3-m.sandoval@proxmox.com> (raw)
In-Reply-To: <20250902124524.368080-1-m.sandoval@proxmox.com>
This is used when performing a full-clone of a running VM.
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
src/PVE/QemuServer/BlockJob.pm | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/PVE/QemuServer/BlockJob.pm b/src/PVE/QemuServer/BlockJob.pm
index 633c0b34..b6e2d51f 100644
--- a/src/PVE/QemuServer/BlockJob.pm
+++ b/src/PVE/QemuServer/BlockJob.pm
@@ -162,8 +162,10 @@ sub qemu_drive_mirror_monitor {
last if $completion eq 'skip' || $completion eq 'auto';
if ($vmiddst && $vmiddst != $vmid) {
+ my $config = PVE::QemuConfig->load_config($vmid);
+ my $fsfreeze = PVE::QemuServer::get_qga_key($config, 'guest-fsfreeze') // 1;
my $agent_running = $qga && qga_check_running($vmid);
- if ($agent_running) {
+ if ($agent_running && $fsfreeze) {
print "freeze filesystem\n";
eval { mon_cmd($vmid, "guest-fsfreeze-freeze"); };
warn $@ if $@;
@@ -176,7 +178,7 @@ sub qemu_drive_mirror_monitor {
# if we clone a disk for a new target vm, we don't switch the disk
qemu_blockjobs_cancel($vmid, $jobs);
- if ($agent_running) {
+ if ($agent_running && $fsfreeze) {
print "unfreeze filesystem\n";
eval { mon_cmd($vmid, "guest-fsfreeze-thaw"); };
warn $@ if $@;
--
2.47.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-09-02 12:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 12:45 [pve-devel] [PATCH container/guest-common/qemu-server v2 0/8] fix #1964: Add a setting to globally disable freezing a guest Maximiliano Sandoval
2025-09-02 12:45 ` [pve-devel] [PATCH qemu-server v2 1/6] add a guest-fsfreeze qga setting Maximiliano Sandoval
2025-09-02 14:43 ` Daniel Kral
2025-09-02 12:45 ` Maximiliano Sandoval [this message]
2025-09-02 12:45 ` [pve-devel] [PATCH qemu-server v2 3/6] fix #1964: follow guest-fsfreeze setting on check freeze needed Maximiliano Sandoval
2025-09-02 12:45 ` [pve-devel] [PATCH qemu-server v2 4/6] log when issuing a guest-fsfreeze command Maximiliano Sandoval
2025-09-02 14:47 ` Daniel Kral
2025-09-02 12:45 ` [pve-devel] [PATCH qemu-server v2 5/6] block job: mirror: reword fsfreeze log entry Maximiliano Sandoval
2025-09-02 12:45 ` [pve-devel] [PATCH qemu-server v2 6/6] deprecate freeze-fs-on-backup qga setting Maximiliano Sandoval
2025-09-02 14:47 ` Daniel Kral
2025-09-02 12:45 ` [pve-devel] [PATCH container v2 1/1] log when freezing/thawing filesystem Maximiliano Sandoval
2025-09-02 12:45 ` [pve-devel] [PATCH guest-common v2 1/1] replication: remove logging when freezing/thawing Maximiliano Sandoval
2025-09-02 15:36 ` [pve-devel] [PATCH container/guest-common/qemu-server v2 0/8] fix #1964: Add a setting to globally disable freezing a guest Daniel Kral
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250902124524.368080-3-m.sandoval@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox