public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH guest-common 1/1] replication: remove logging when freezing/thawing
Date: Fri, 29 Aug 2025 13:43:36 +0200	[thread overview]
Message-ID: <20250829114337.345358-4-m.sandoval@proxmox.com> (raw)
In-Reply-To: <20250829114337.345358-1-m.sandoval@proxmox.com>

This is handled now by the class' __snapshot_freeze.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 src/PVE/Replication.pm | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/PVE/Replication.pm b/src/PVE/Replication.pm
index ba4c2c1..1b31ae2 100644
--- a/src/PVE/Replication.pm
+++ b/src/PVE/Replication.pm
@@ -376,7 +376,6 @@ sub replicate {
 
     # freeze filesystem for data consistency
     if ($freezefs) {
-        $logfunc->("freeze guest filesystem");
         $guest_class->__snapshot_freeze($vmid, 0);
     }
 
@@ -395,7 +394,6 @@ sub replicate {
 
     # thaw immediately
     if ($freezefs) {
-        $logfunc->("thaw guest filesystem");
         $guest_class->__snapshot_freeze($vmid, 1);
     }
 
-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2025-08-29 11:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-29 11:43 [pve-devel] [PATCH container/guest-common/qemu-server 0/3] log when freezing or thawing the guest's fs Maximiliano Sandoval
2025-08-29 11:43 ` [pve-devel] [PATCH qemu-server 1/1] log when issues a guest-fsfreeze command Maximiliano Sandoval
2025-08-29 11:45   ` Maximiliano Sandoval
2025-08-29 11:43 ` [pve-devel] [PATCH container 1/1] log when freezing/thawing filesystem Maximiliano Sandoval
2025-08-29 11:43 ` Maximiliano Sandoval [this message]
2025-09-01 13:03 ` [pve-devel] [PATCH container/guest-common/qemu-server 0/3] log when freezing or thawing the guest's fs Shannon Sterz
2025-09-02 12:46 ` [pve-devel] superseded: " Maximiliano Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250829114337.345358-4-m.sandoval@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal