[pve-devel] [PATCH container/qemu-server v4 0/2] Fix RRD PNG Graph creation

[pve-devel] [PATCH container/qemu-server v4 0/2] Fix RRD PNG Graph creation

[Aaron Lauterer]

This series fixes the RRD graph generation to PNGs for CTs and VMs.

qemu-server:

Aaron Lauterer (1):
  api: rrd: add missing ds parameter for png graph

 src/PVE/API2/Qemu.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


container:

Aaron Lauterer (1):
  api: rrd: add missing ds parameter for png graph

 src/PVE/API2/LXC.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Summary over all repositories:
  2 files changed, 2 insertions(+), 2 deletions(-)

-- 
Generated by git-murpp 0.8.1


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH qemu-server v4 1/1] api: rrd: add missing ds parameter for png graph

[Aaron Lauterer]

Otherwise, no png would be generated if that parameter is omitted

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
 src/PVE/API2/Qemu.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm
index b571e6c1..6069c3a9 100644
--- a/src/PVE/API2/Qemu.pm
+++ b/src/PVE/API2/Qemu.pm
@@ -1632,7 +1632,7 @@ __PACKAGE__->register_method({
 
         my $path = "pve-vm-9.0/$param->{vmid}";
         $path = "pve2-vm/$param->{vmid}" if !-e "/var/lib/rrdcached/db/${path}";
-        return PVE::RRD::create_rrd_graph($path, $param->{timeframe}, $param->{cf});
+        return PVE::RRD::create_rrd_graph($path, $param->{timeframe}, $param->{ds}, $param->{cf});
 
     },
 });
-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH container v4 1/1] api: rrd: add missing ds parameter for png graph

[Aaron Lauterer]

Otherwise, no png would be generated if that parameter is omitted

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
 src/PVE/API2/LXC.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
index 17035f4..1f89c87 100644
--- a/src/PVE/API2/LXC.pm
+++ b/src/PVE/API2/LXC.pm
@@ -720,7 +720,7 @@ __PACKAGE__->register_method({
 
         my $path = "pve-vm-9.0/$param->{vmid}";
         $path = "pve2-vm/$param->{vmid}" if !-e "/var/lib/rrdcached/db/${path}";
-        return PVE::RRD::create_rrd_graph($path, $param->{timeframe}, $param->{cf});
+        return PVE::RRD::create_rrd_graph($path, $param->{timeframe}, $param->{ds}, $param->{cf});
 
     },
 });
-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH container/qemu-server v4 0/2] Fix RRD PNG Graph creation

[Aaron Lauterer]

ping

we got a few reports from people in the forum that run into the issue of 
not getting back graphs as pngs

On  2025-08-28  14:58, Aaron Lauterer wrote:
> This series fixes the RRD graph generation to PNGs for CTs and VMs.
> 
> qemu-server:
> 
> Aaron Lauterer (1):
>    api: rrd: add missing ds parameter for png graph
> 
>   src/PVE/API2/Qemu.pm | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> container:
> 
> Aaron Lauterer (1):
>    api: rrd: add missing ds parameter for png graph
> 
>   src/PVE/API2/LXC.pm | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> Summary over all repositories:
>    2 files changed, 2 insertions(+), 2 deletions(-)
> 



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH container/qemu-server v4 0/2] Fix RRD PNG Graph creation

[Michael Köppl]

Tested this by manually calling both API endpoints. With the patches
applied, the returned filename now contains the data sources provided in
the params and also returns data for the image again.

Tested-by: Michael Köppl <m.koeppl@proxmox.com>

On Thu Aug 28, 2025 at 2:58 PM CEST, Aaron Lauterer wrote:
> This series fixes the RRD graph generation to PNGs for CTs and VMs.
>
> qemu-server:
>
> Aaron Lauterer (1):
>   api: rrd: add missing ds parameter for png graph
>
>  src/PVE/API2/Qemu.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> container:
>
> Aaron Lauterer (1):
>   api: rrd: add missing ds parameter for png graph
>
>  src/PVE/API2/LXC.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> Summary over all repositories:
>   2 files changed, 2 insertions(+), 2 deletions(-)



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied-series: [PATCH container/qemu-server v4 0/2] Fix RRD PNG Graph creation

[Thomas Lamprecht]

Am 28.08.25 um 14:58 schrieb Aaron Lauterer:
> This series fixes the RRD graph generation to PNGs for CTs and VMs.
> 
> qemu-server:
> 
> Aaron Lauterer (1):
>   api: rrd: add missing ds parameter for png graph
> 
>  src/PVE/API2/Qemu.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> container:
> 
> Aaron Lauterer (1):
>   api: rrd: add missing ds parameter for png graph
> 
>  src/PVE/API2/LXC.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> Summary over all repositories:
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 


applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel