public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] ui: pool: members: fix store reload on add/remove
Date: Wed, 27 Aug 2025 12:14:16 +0200	[thread overview]
Message-ID: <20250827101430.424606-2-c.heiss@proxmox.com> (raw)

.load() must be called on the underlying UpdateStore, not on the
DiffStore.

Currently, this results in the members list being cleared after
adding/removing an entry, only being reloaded (correctly) during the
next automatic background update.

Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
 www/manager6/grid/PoolMembers.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/www/manager6/grid/PoolMembers.js b/www/manager6/grid/PoolMembers.js
index f025a1380..de5104434 100644
--- a/www/manager6/grid/PoolMembers.js
+++ b/www/manager6/grid/PoolMembers.js
@@ -188,8 +188,8 @@ Ext.define('PVE.grid.PoolMembers', {
             (c) => c.dataIndex !== 'tags' && c.dataIndex !== 'lock',
         );
 
-        var reload = function () {
-            store.load();
+        const reload = function () {
+            me.rstore.load();
         };
 
         var sm = Ext.create('Ext.selection.RowModel', {});
-- 
2.50.1



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


             reply	other threads:[~2025-08-27 10:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-27 10:14 Christoph Heiss [this message]
2025-09-02 12:32 ` [pve-devel] applied: " Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250827101430.424606-2-c.heiss@proxmox.com \
    --to=c.heiss@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal