public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Gabriel Goller <g.goller@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-network 1/1] fabrics: add IS-IS api types
Date: Tue, 19 Aug 2025 15:19:06 +0200	[thread overview]
Message-ID: <20250819131916.324392-8-g.goller@proxmox.com> (raw)
In-Reply-To: <20250819131916.324392-1-g.goller@proxmox.com>

Add IS-IS api-types and add it to the protocol enum. Also make 'isisd' a
frr daemon managed by pve (This means we can enable and disable it).

Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
 src/PVE/Network/SDN/Fabrics.pm | 47 +++++++++++++++++++++++++++++-----
 src/PVE/Network/SDN/Frr.pm     |  1 +
 2 files changed, 42 insertions(+), 6 deletions(-)

diff --git a/src/PVE/Network/SDN/Fabrics.pm b/src/PVE/Network/SDN/Fabrics.pm
index d90992a7eceb..63f4f1497117 100644
--- a/src/PVE/Network/SDN/Fabrics.pm
+++ b/src/PVE/Network/SDN/Fabrics.pm
@@ -45,7 +45,7 @@ PVE::JSONSchema::register_standard_option(
     {
         description => "Type of configuration entry in an SDN Fabric section config",
         type => 'string',
-        enum => ['openfabric', 'ospf'],
+        enum => ['openfabric', 'ospf', 'isis'],
     },
 );
 
@@ -181,6 +181,41 @@ sub node_properties {
                     description => 'OpenFabric network interface',
                     optional => 1,
                 },
+                {
+                    type => 'array',
+                    'instance-types' => ['isis'],
+                    items => {
+                        type => 'string',
+                        format => {
+                            name => {
+                                type => 'string',
+                                format => 'pve-iface',
+                                description => 'Name of the network interface',
+                            },
+                            hello_multiplier => {
+                                type => 'integer',
+                                description => 'The hello_multiplier property of the interface',
+                                optional => 1,
+                                minimum => 2,
+                                maximum => 100,
+                            },
+                            ip => {
+                                type => 'string',
+                                format => 'CIDRv4',
+                                description => 'IPv4 address for this node',
+                                optional => 1,
+                            },
+                            ip6 => {
+                                type => 'string',
+                                format => 'CIDRv6',
+                                description => 'IPv6 address for this node',
+                                optional => 1,
+                            },
+                        },
+                    },
+                    description => 'IS-IS network interface',
+                    optional => 1,
+                },
                 {
                     type => 'array',
                     'instance-types' => ['ospf'],
@@ -244,8 +279,8 @@ sub fabric_properties {
         hello_interval => {
             type => 'number',
             'type-property' => 'protocol',
-            'instance-types' => ['openfabric'],
-            description => 'The hello_interval property for Openfabric',
+            'instance-types' => ['openfabric', 'isis'],
+            description => 'The hello_interval property for Openfabric and IS-IS',
             optional => 1,
             minimum => 1,
             maximum => 600,
@@ -253,8 +288,8 @@ sub fabric_properties {
         csnp_interval => {
             type => 'number',
             'type-property' => 'protocol',
-            'instance-types' => ['openfabric'],
-            description => 'The csnp_interval property for Openfabric',
+            'instance-types' => ['openfabric', 'isis'],
+            description => 'The csnp_interval property for Openfabric and IS-IS',
             optional => 1,
             minimum => 1,
             maximum => 600,
@@ -277,7 +312,7 @@ sub fabric_properties {
             oneOf => [
                 {
                     type => 'array',
-                    'instance-types' => ['openfabric'],
+                    'instance-types' => ['openfabric', 'isis'],
                     items => {
                         type => 'string',
                         enum => ['hello_interval', 'csnp_interval'],
diff --git a/src/PVE/Network/SDN/Frr.pm b/src/PVE/Network/SDN/Frr.pm
index b548e7b4f0fe..4e933710d967 100644
--- a/src/PVE/Network/SDN/Frr.pm
+++ b/src/PVE/Network/SDN/Frr.pm
@@ -112,6 +112,7 @@ sub restart {
 my $SDN_DAEMONS_DEFAULT = {
     ospfd => 0,
     fabricd => 0,
+    isisd => 0,
 };
 
 =head3 set_daemon_status(\%daemons, $set_default)
-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2025-08-19 13:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-19 13:18 [pve-devel] [PATCH docs/gui-tests/manager/network/proxmox{-ve-rs, -perl-rs} 0/9] Add IS-IS protocol to fabrics Gabriel Goller
2025-08-19 13:19 ` [pve-devel] [PATCH proxmox-ve-rs 1/3] frr: add IS-IS frr configuration types Gabriel Goller
2025-08-19 13:19 ` [pve-devel] [PATCH proxmox-ve-rs 2/3] ve-config: add IS-IS fabric config parsing and frr config generation Gabriel Goller
2025-08-19 13:19 ` [pve-devel] [PATCH proxmox-ve-rs 3/3] ve-config: add integration tests for IS-IS fabrics Gabriel Goller
2025-08-19 13:19 ` [pve-devel] [PATCH proxmox-perl-rs 1/1] pve-rs: fabrics: add IS-IS protocol ifupdown config generation Gabriel Goller
2025-08-19 13:19 ` [pve-devel] [PATCH pve-manager 1/2] fabrics: add IS-IS panels Gabriel Goller
2025-08-19 13:19 ` [pve-devel] [PATCH pve-manager 2/2] sdn: add warning about IS-IS controller deprecation Gabriel Goller
2025-08-19 13:19 ` Gabriel Goller [this message]
2025-08-19 13:19 ` [pve-devel] [PATCH pve-docs 1/1] sdn: add section about IS-IS fabric Gabriel Goller
2025-08-19 13:19 ` [pve-devel] [PATCH pve-gui-tests 1/1] fabrics: add screenshots for IS-IS fabric and nodes Gabriel Goller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250819131916.324392-8-g.goller@proxmox.com \
    --to=g.goller@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal