public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Shan Shaji <s.shaji@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve_flutter_frontend v5 1/3] ui: ios: enable noVNC console support
Date: Mon, 18 Aug 2025 12:01:32 +0200	[thread overview]
Message-ID: <20250818100134.30550-2-s.shaji@proxmox.com> (raw)
In-Reply-To: <20250818100134.30550-1-s.shaji@proxmox.com>

The noVNC console was disabled in iOS and was only available in android

To fix the issue, add additional platform check for iOS and enabled the
noVNC console option.

Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
---
 lib/widgets/pve_console_menu_widget.dart | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/lib/widgets/pve_console_menu_widget.dart b/lib/widgets/pve_console_menu_widget.dart
index 473595d..6de2c0b 100644
--- a/lib/widgets/pve_console_menu_widget.dart
+++ b/lib/widgets/pve_console_menu_widget.dart
@@ -97,7 +97,7 @@ class PveConsoleMenu extends StatelessWidget {
                   }
                 },
               ),
-            if (Platform.isAndroid) // web_view is only available for mobile :(
+            if (Platform.isAndroid || Platform.isIOS) // web_view is only available for mobile :(
               ListTile(
                 title: const Text(
                   //type == "qemu" ? "noVNC Console" : "xterm.js Console",
@@ -106,7 +106,6 @@ class PveConsoleMenu extends StatelessWidget {
                 ),
                 subtitle: const Text("Open console view"),
                 onTap: () async {
-                  if (Platform.isAndroid) {
                     if (['qemu', 'lxc'].contains(type)) {
                       SystemChrome.setEnabledSystemUIMode(
                           SystemUiMode.immersive);
@@ -134,9 +133,6 @@ class PveConsoleMenu extends StatelessWidget {
                             ]);
                       });
                     }
-                  } else {
-                    print('not implemented for current platform');
-                  }
                 },
               ),
           ],
-- 
2.50.1



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2025-08-18 10:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-18 10:01 [pve-devel] [PATCH pve_flutter_frontend v5 0/3] fix: enable noVNC console view in iOS and refactor console view implementation Shan Shaji
2025-08-18 10:01 ` Shan Shaji [this message]
2025-08-18 10:01 ` [pve-devel] [PATCH pve_flutter_frontend v5 2/3] refactor: noVNC: seperate duplicate onTap implementation Shan Shaji
2025-08-18 10:01 ` [pve-devel] [PATCH pve_flutter_frontend v5 3/3] fix: ui: make noVNC console dismissible and prevent body resize Shan Shaji
2025-09-04  7:33 ` [pve-devel] [PATCH pve_flutter_frontend v5 0/3] fix: enable noVNC console view in iOS and refactor console view implementation Shan Shaji

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250818100134.30550-2-s.shaji@proxmox.com \
    --to=s.shaji@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal