From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH-SERIES qemu-server v2 0/3] qmp: improve error handling for mon_cmd()
Date: Tue, 12 Aug 2025 13:56:28 +0200 [thread overview]
Message-ID: <20250812115652.79330-1-f.ebner@proxmox.com> (raw)
Changes in v2:
* use eval+warn around new detach() call sites, as failure should not
be critical there.
Add a new noerr argument to mon_cmd() to allow callers to opt-in to
handling errors themselves.
Without passing 'noerr' to mon_cmd(), errors are logged to the system
journal. In the blockdev module, in attach() and detach(), there are
two mon_cmd() calls that are expected to fail in some scenarios for
which the errors should not be logged.
Again in the blockdev module, the functions for deletion and replace
had the same issue. Have them re-use the detach() function.
Fiona Ebner (3):
qmp client: add $noerr argument
blockdev: attach/detach: silence errors for QMP commands for which
failure may be expected
blockdev: delete/replace: re-use detach() helper
src/PVE/QMPClient.pm | 8 ++++---
src/PVE/QemuServer/Blockdev.pm | 16 ++++++--------
src/PVE/QemuServer/Monitor.pm | 40 +++++++++++++++++++++++++++++++---
3 files changed, 49 insertions(+), 15 deletions(-)
--
2.47.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-08-12 11:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 11:56 Fiona Ebner [this message]
2025-08-12 11:56 ` [pve-devel] [PATCH qemu-server v2 1/3] qmp client: add $noerr argument Fiona Ebner
2025-08-12 11:56 ` [pve-devel] [PATCH qemu-server v2 2/3] blockdev: attach/detach: silence errors for QMP commands for which failure may be expected Fiona Ebner
2025-08-12 11:56 ` [pve-devel] [PATCH qemu-server v2 3/3] blockdev: delete/replace: re-use detach() helper Fiona Ebner
2025-08-12 12:51 ` [pve-devel] applied-series: [PATCH-SERIES qemu-server v2 0/3] qmp: improve error handling for mon_cmd() Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250812115652.79330-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox