From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] ui: storage edit: warn about disabling snapshot-as-volume-chain on LVM
Date: Tue, 12 Aug 2025 10:28:14 +0200 [thread overview]
Message-ID: <20250812082824.30625-1-f.ebner@proxmox.com> (raw)
Existing qcow2 volumes on a storage won't be handled correctly anymore
after the setting is turned off. The setting is already a fixed
storage setting for directory-based storages, so this is only relevant
for LVM. Could be improved by checking in the backend if there are any
qcow2 images and only allow turning it off if not, but this requires
changes to the on_update_hook() signature. Until then, warn in the
front-end.
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
Went with a warning rather than disallowing, so that the limitation
gets visibly communicated to the user.
www/manager6/storage/Base.js | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/www/manager6/storage/Base.js b/www/manager6/storage/Base.js
index 84c08f2c..cf89ef6d 100644
--- a/www/manager6/storage/Base.js
+++ b/www/manager6/storage/Base.js
@@ -90,6 +90,14 @@ Ext.define('PVE.panel.StorageBase', {
});
me.advancedColumnB = me.advancedColumnB || [];
+ if (me.type === 'lvm') {
+ me.advancedColumnB.unshift({
+ xtype: 'displayfield',
+ name: 'external-snapshot-hint-lvm',
+ userCls: 'pmx-hint',
+ value: gettext('Keep Snapshots as Volume-Chain enabled if qcow2 images exist!'),
+ });
+ }
me.advancedColumnB.unshift({
xtype: 'displayfield',
name: 'external-snapshot-hint',
--
2.47.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-08-12 8:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 8:28 Fiona Ebner [this message]
2025-08-12 10:23 ` [pve-devel] applied: " Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250812082824.30625-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox