public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Kamil Trzcinski <ayufan@ayufan.eu>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-common] syscall: use mknodat instead of mknod
Date: Mon, 11 Aug 2025 09:56:14 +0200	[thread overview]
Message-ID: <20250811075614.146993-1-ayufan@ayufan.eu> (raw)

On arm64 the `SYS_mknod` is not available,
replace it with use of `SYS_mknodat`.

Signed-off-by: Kamil Trzcinski <ayufan@ayufan.eu>
---
 src/PVE/Syscall.pm | 2 +-
 src/PVE/Tools.pm   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/PVE/Syscall.pm b/src/PVE/Syscall.pm
index 68e16fe..503d3fe 100644
--- a/src/PVE/Syscall.pm
+++ b/src/PVE/Syscall.pm
@@ -17,7 +17,7 @@ BEGIN {
         openat => &SYS_openat,
         close => &SYS_close,
         mkdirat => &SYS_mkdirat,
-        mknod => &SYS_mknod,
+        mknodat => &SYS_mknodat,
         faccessat => &SYS_faccessat,
         setresuid => &SYS_setresuid,
         fallocate => &SYS_fallocate,
diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
index fe9616e..f3c6e81 100644
--- a/src/PVE/Tools.pm
+++ b/src/PVE/Tools.pm
@@ -1817,7 +1817,7 @@ sub mkdirat($$$) {
 
 sub mknod($$$) {
     my ($filename, $mode, $dev) = @_;
-    return syscall(PVE::Syscall::mknod, $filename, int($mode), int($dev)) == 0;
+    return syscall(PVE::Syscall::mknodat, AT_FDCWD, $filename, int($mode), int($dev)) == 0;
 }
 
 sub fchownat($$$$$) {
-- 
2.47.2


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


                 reply	other threads:[~2025-08-11  7:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250811075614.146993-1-ayufan@ayufan.eu \
    --to=ayufan@ayufan.eu \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal