From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 2/2] d/postinst: lvm config: check that --clear-needs-check-flag is set if there is a thin_check_options override
Date: Fri, 8 Aug 2025 16:03:24 +0200 [thread overview]
Message-ID: <20250808140419.119992-3-f.ebner@proxmox.com> (raw)
In-Reply-To: <20250808140419.119992-1-f.ebner@proxmox.com>
Quoting the commit message from [0] verbatim:
thin_check v1.0.x reveals data block ref count issue that is not being
detected by previous versions, which blocks the pool from activation if
there are any leaked blocks. To reduce potential user complaints on
inactive pools after upgrading and also maintain backward compatibility
between LVM and older thin_check, we decided to adopt the 'auto-repair'
functionality in the --clear-needs-check-flag option, rather than
passing --auto-repair from lvm.conf.
[0]: https://github.com/device-mapper-utils/thin-provisioning-tools/commit/eb28ab94
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
debian/postinst | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/debian/postinst b/debian/postinst
index b1761c24..b6e07fd9 100755
--- a/debian/postinst
+++ b/debian/postinst
@@ -238,6 +238,14 @@ case "$1" in
/usr/libexec/proxmox/proxmox-rrd-migration-tool --migrate || \
echo "migration failed, see output above for errors and try to migrate existing data manually by running '/usr/libexec/proxmox/proxmox-rrd-migration-tool --migrate'"
fi
+
+ if test -n "$2" && dpkg --compare-versions "$2" 'lt' '9.0.4'; then
+ if test -e /etc/lvm/lvm.conf && grep "^\s*thin_check_options" /etc/lvm/lvm.conf | grep -qv -- "--clear-needs-check-flag"; then
+ printf '\nNOTE: Detected override for 'thin_check_options' without '--clear-needs-check-flag' option in /etc/lvm/lvm.conf\n'
+ printf 'Add the option to the override or thin pools with minor issues might not automatically activate anymore!\n\n'
+ fi
+ fi
+
;;
abort-upgrade|abort-remove|abort-deconfigure)
--
2.47.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-08-08 14:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-08 14:03 [pve-devel] [PATCH-SERIES manager 0/2] " Fiona Ebner
2025-08-08 14:03 ` [pve-devel] [PATCH manager 1/2] 8 to 9: " Fiona Ebner
2025-08-08 14:03 ` Fiona Ebner [this message]
2025-08-08 14:19 ` [pve-devel] [PATCH-SERIES manager 0/2] " Fabian Grünbichler
2025-08-08 14:23 ` Fiona Ebner
2025-08-08 14:19 ` [pve-devel] applied: " Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250808140419.119992-3-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox