From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-network v2 1/1] sdn: api: always send regenerate-frr parameter
Date: Tue, 5 Aug 2025 10:35:02 +0200 [thread overview]
Message-ID: <20250805083504.55378-3-s.hanreich@proxmox.com> (raw)
In-Reply-To: <20250805083504.55378-1-s.hanreich@proxmox.com>
This makes it possible to check for the definedness of the parameter
and adapt the behavior of the reloading endpoint depending on that
information. See the commit in pve-manager for more information.
Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
src/PVE/API2/Network/SDN.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/PVE/API2/Network/SDN.pm b/src/PVE/API2/Network/SDN.pm
index 16a8e2c..af00b1a 100644
--- a/src/PVE/API2/Network/SDN.pm
+++ b/src/PVE/API2/Network/SDN.pm
@@ -93,7 +93,7 @@ my $create_reload_network_worker = sub {
my ($nodename, $regenerate_frr) = @_;
my @command = ('pvesh', 'set', "/nodes/$nodename/network");
- push(@command, '--regenerate-frr') if $regenerate_frr;
+ push(@command, '--regenerate-frr', $regenerate_frr);
# FIXME: how to proxy to final node ?
my $upid;
@@ -299,7 +299,7 @@ __PACKAGE__->register_method({
$lock_token,
);
- my $regenerate_frr = $previous_config_has_frr || $new_config_has_frr;
+ my $regenerate_frr = ($previous_config_has_frr || $new_config_has_frr) ? 1 : 0;
my $code = sub {
$rpcenv->{type} = 'priv'; # to start tasks in background
--
2.47.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-08-05 8:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-05 8:35 [pve-devel] [PATCH manager/network v2 0/2] Improve FRR reloading logic Stefan Hanreich
2025-08-05 8:35 ` [pve-devel] [PATCH pve-manager v2 1/1] network: improve " Stefan Hanreich
2025-08-05 8:35 ` Stefan Hanreich [this message]
2025-08-05 8:36 ` [pve-devel] superseded: [PATCH manager/network v2 0/2] Improve FRR " Stefan Hanreich
2025-08-05 8:49 ` Stefan Hanreich
2025-08-05 9:22 ` [pve-devel] " Gabriel Goller
2025-08-05 9:43 ` Hannes Duerr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250805083504.55378-3-s.hanreich@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox