public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager/network 0/2] Improve FRR reloading logic
Date: Tue,  5 Aug 2025 10:29:22 +0200	[thread overview]
Message-ID: <20250805082926.48280-1-s.hanreich@proxmox.com> (raw)

Follow-up to the stop gap fix in [1].

This should handle all cases that we need to consider:

* Do not overwrite existing FRR configurations, unless we need to generate our
own FRR configuration.

* Do not trigger a FRR enable when reloading the host configuration, even though
there is no FRR configuration.

* Overwrite the FRR configuration with an empty configuration if all SDN
entities using FRR got deleted.

* Regenerate the FRR configuration when the host network configuration changes,
since this might affect the generated FRR configuration.


[1] https://git.proxmox.com/?p=pve-manager.git;a=commit;h=6c5295a1cdb6ec872ddf997cae030817dffff106

pve-manager:

Stefan Hanreich (1):
  network: improve reloading logic

 PVE/API2/Network.pm | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)


pve-network:

Stefan Hanreich (1):
  sdn: api: always send regenerate-frr parameter

 src/PVE/API2/Network/SDN.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


Summary over all repositories:
  2 files changed, 9 insertions(+), 3 deletions(-)

-- 
Generated by git-murpp 0.8.0

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


             reply	other threads:[~2025-08-05  8:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-05  8:29 Stefan Hanreich [this message]
2025-08-05  8:29 ` [pve-devel] [PATCH pve-manager 1/1] network: improve " Stefan Hanreich
2025-08-05  8:29 ` [pve-devel] [PATCH pve-network 1/1] sdn: api: always send regenerate-frr parameter Stefan Hanreich
2025-08-05  8:57 ` [pve-devel] [PATCH manager/network 0/2] Improve FRR reloading logic Friedrich Weber
2025-08-05  9:11 ` Gabriel Goller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250805082926.48280-1-s.hanreich@proxmox.com \
    --to=s.hanreich@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal