From: Daniel Kral <d.kral@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH ha-manager 1/2] manager: support older versioning schema for ha group migration
Date: Mon, 4 Aug 2025 16:20:53 +0200 [thread overview]
Message-ID: <20250804142212.212744-1-d.kral@proxmox.com> (raw)
Prior to the Proxmox VE 8.x series, the pve-manager is versioned in the
format of `M.m-p`. Versions prior to Proxmox VE 8.x are already EOL'd,
but this change prevents any "Use of uninitialized value" log messages
if one of the nodes is on a version with such a versioning scheme.
Signed-off-by: Daniel Kral <d.kral@proxmox.com>
---
Missed that patch in the v2 for the follow-up for the ha-manager (but
was included in the v1).
Not really important (i.e. doesn't result in any fatal errors), but gets
rid of a "use of unitialized value" warning from perl while running the
tests/looking in the syslog in the rather unlikely (unsupported) case
that one has the CRM node running PVE 9.* and another node still running
7.4...
src/PVE/HA/Manager.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm
index 884d098b..ba59f642 100644
--- a/src/PVE/HA/Manager.pm
+++ b/src/PVE/HA/Manager.pm
@@ -539,7 +539,7 @@ my $have_groups_been_migrated = sub {
my $get_version_parts = sub {
my ($node_version) = @_;
- return $node_version =~ m/^(\d+)\.(\d+)\.(\d+)(?:~(\d+))?/;
+ return $node_version =~ m/^(\d+)\.(\d+)(?:\.|-)(\d+)(?:~(\d+))?/;
};
my $has_node_min_version = sub {
--
2.47.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-08-04 14:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 14:20 Daniel Kral [this message]
2025-08-04 14:20 ` [pve-devel] [PATCH ha-manager 2/2] tree-wide: update description of pve-ha-node-list standard option Daniel Kral
2025-08-04 19:33 ` [pve-devel] applied: [PATCH ha-manager 1/2] manager: support older versioning schema for ha group migration Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250804142212.212744-1-d.kral@proxmox.com \
--to=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox