public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager/network 0/2] do not apply FRR configuration when reloading host network configuration
Date: Mon,  4 Aug 2025 15:47:02 +0200	[thread overview]
Message-ID: <20250804134706.408039-1-s.hanreich@proxmox.com> (raw)

The FRR apply function was called when omitting the skip_frr parameter, which is
the case when saving the host network configuration via the Web UI, leading to
an enabled FRR daemon after saving the network configuration.

In a follow-up we should also consider checking if the previous configuration
contained FRR entities, but the new one doesn't and disable the FRR daemon in
this case.

pve-manager:

Stefan Hanreich (1):
  api: network: default to not regenerating the frr configuration

 PVE/API2/Network.pm | 7 ++++---
 bin/pve-sdn-commit  | 4 ++--
 2 files changed, 6 insertions(+), 5 deletions(-)


pve-network:

Stefan Hanreich (1):
  sdn: api: rename parameter from skip-frr to regenerate-frr

 src/PVE/API2/Network/SDN.pm | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)


Summary over all repositories:
  3 files changed, 10 insertions(+), 11 deletions(-)

-- 
Generated by git-murpp 0.8.0

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


             reply	other threads:[~2025-08-04 13:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-04 13:47 Stefan Hanreich [this message]
2025-08-04 13:47 ` [pve-devel] [PATCH pve-manager 1/1] api: network: default to not regenerating the frr configuration Stefan Hanreich
2025-08-04 14:07   ` Thomas Lamprecht
2025-08-04 14:11     ` Stefan Hanreich
2025-08-04 14:13       ` Stefan Hanreich
2025-08-04 13:47 ` [pve-devel] [PATCH pve-network 1/1] sdn: api: rename parameter from skip-frr to regenerate-frr Stefan Hanreich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250804134706.408039-1-s.hanreich@proxmox.com \
    --to=s.hanreich@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal