From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH cluster 1/5] pmxcfs: status: add one more missing g_free
Date: Fri, 1 Aug 2025 11:54:27 +0200 [thread overview]
Message-ID: <20250801095431.117317-1-l.wagner@proxmox.com> (raw)
Otherwise we leak the memory that was already allocated for `filename`.
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
src/pmxcfs/status.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/pmxcfs/status.c b/src/pmxcfs/status.c
index a00e793..886d0bd 100644
--- a/src/pmxcfs/status.c
+++ b/src/pmxcfs/status.c
@@ -1369,6 +1369,8 @@ static void update_rrd_data(const char *key, gconstpointer data, size_t len) {
} else if (g_file_test(filename_pve2, G_FILE_TEST_EXISTS)) {
// old file exists, use it
use_pve2_file = 1;
+
+ g_free(filename);
filename = g_strdup_printf("%s", filename_pve2);
} else {
// neither file exists, check for directories to decide and create file
--
2.47.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-08-01 9:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-01 9:54 Lukas Wagner [this message]
2025-08-01 9:54 ` [pve-devel] [PATCH cluster 2/5] pmxcfs: status: avoid unnecessary string allocations Lukas Wagner
2025-08-01 9:54 ` [pve-devel] [PATCH cluster 3/5] pmxcfs: status: call g_strdup instead of g_strdup_printf when no formatting is needed Lukas Wagner
2025-08-01 9:54 ` [pve-devel] [PATCH cluster 4/5] pmxcfs: status: remove string literal params for g_strdup_printf Lukas Wagner
2025-08-01 9:54 ` [pve-devel] [PATCH cluster 5/5] pmxcfs: status: avoid g_strdup when not needed Lukas Wagner
2025-08-01 11:32 ` [pve-devel] [PATCH cluster 1/5] pmxcfs: status: add one more missing g_free Maximiliano Sandoval
2025-08-01 12:52 ` Thomas Lamprecht
2025-08-01 13:04 ` Lukas Wagner
2025-08-01 12:55 ` Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250801095431.117317-1-l.wagner@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox