From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH storage 2/4] fix #6584: plugin: list_images: only include parseable filenames
Date: Thu, 31 Jul 2025 13:15:17 +0200 [thread overview]
Message-ID: <20250731111519.931104-3-f.gruenbichler@proxmox.com> (raw)
In-Reply-To: <20250731111519.931104-1-f.gruenbichler@proxmox.com>
by only including filenames that are also valid when actually parsing them,
things like snapshot files or files not following our naming scheme are no
longer candidates for rescanning or included in other output.
Co-authored-by: Shannon Sterz <s.sterz@proxmox.com>
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
src/PVE/Storage/Plugin.pm | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm
index c08f5a5..affe7b0 100644
--- a/src/PVE/Storage/Plugin.pm
+++ b/src/PVE/Storage/Plugin.pm
@@ -1555,6 +1555,10 @@ sub list_images {
next if !$vollist && defined($vmid) && ($owner ne $vmid);
+ # skip files that are snapshots or have invalid names
+ my ($parsed_name) = eval { parse_name_dir(basename($fn)) };
+ next if !defined($parsed_name);
+
my ($size, undef, $used, $parent, $ctime) = eval { file_size_info($fn, undef, $format); };
if (my $err = $@) {
die $err if $err !~ m/Image is not in \S+ format$/;
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-31 11:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 11:15 [pve-devel] [PATCH storage 0/4] fix snapshot filename regressions Fabian Grünbichler
2025-07-31 11:15 ` [pve-devel] [PATCH storage 1/4] plugin: fix parse_name_dir regression for custom volume names Fabian Grünbichler
2025-07-31 11:15 ` Fabian Grünbichler [this message]
2025-07-31 11:15 ` [pve-devel] [PATCH storage 3/4] plugin: extend snapshot name parsing to legacy volnames Fabian Grünbichler
2025-07-31 12:09 ` Fiona Ebner
2025-07-31 12:20 ` Fabian Grünbichler
2025-07-31 12:32 ` Fiona Ebner
2025-07-31 11:15 ` [pve-devel] [RFC storage 4/4] plugin: parse_name_dir: drop deprecation warning Fabian Grünbichler
2025-07-31 12:17 ` Fiona Ebner
2025-07-31 12:06 ` [pve-devel] [PATCH storage 0/4] fix snapshot filename regressions Shannon Sterz
2025-07-31 12:17 ` [pve-devel] applied: " Thomas Lamprecht
2025-07-31 12:24 ` [pve-devel] " Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250731111519.931104-3-f.gruenbichler@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox