From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server v5 08/11] migrate: flush old VM conntrack entries after successful migration
Date: Wed, 30 Jul 2025 11:45:42 +0200 [thread overview]
Message-ID: <20250730094549.263805-9-c.heiss@proxmox.com> (raw)
In-Reply-To: <20250730094549.263805-1-c.heiss@proxmox.com>
After a successful live-migration, the old VM-specific conntrack entries
are not needed anymore on the source node and can thus be flushed.
Tested-by: Stefan Hanreich <s.hanreich@proxmox.com>
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
Changes v1 -> v2:
* no changes
Changes v2 -> v3:
* formatted using perltidy
* adjusted info message by adding `[on source] node` at end for
better context
Changes v3 -> v4:
* no changes
Changes v4 -> v5:
* no changes
src/PVE/QemuMigrate.pm | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/src/PVE/QemuMigrate.pm b/src/PVE/QemuMigrate.pm
index e4fbcbbe..e18cc2aa 100644
--- a/src/PVE/QemuMigrate.pm
+++ b/src/PVE/QemuMigrate.pm
@@ -11,6 +11,7 @@ use Time::HiRes qw( usleep );
use PVE::AccessControl;
use PVE::Cluster;
use PVE::Format qw(render_bytes);
+use PVE::Firewall::Helpers;
use PVE::GuestHelpers qw(safe_boolean_ne safe_string_ne);
use PVE::INotify;
use PVE::JSONSchema;
@@ -1761,6 +1762,10 @@ sub phase3_cleanup {
if (my $err = $@) {
$self->log('warn', "failed to stop dbus-vmstate on $targetnode: $err\n");
}
+
+ # also flush now-old local conntrack entries for the migrated VM
+ $self->log('info', 'flushing conntrack state for guest on source node');
+ PVE::Firewall::Helpers::flush_fw_ct_entries_by_mark($vmid);
}
}
--
2.49.0
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-30 9:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-30 9:45 [pve-devel] [PATCH firewall/qemu-server/manager/docs v5 00/11] fix #5180: migrate conntrack state on live migration Christoph Heiss
2025-07-30 9:45 ` [pve-devel] [PATCH proxmox-firewall v5 01/11] firewall: add connmark rule with VMID to all guest chains Christoph Heiss
2025-07-30 9:45 ` [pve-devel] [PATCH firewall v5 02/11] " Christoph Heiss
2025-07-30 9:45 ` [pve-devel] [PATCH firewall v5 03/11] firewall: helpers: add sub for flushing conntrack entries by mark Christoph Heiss
2025-07-30 9:45 ` [pve-devel] [PATCH qemu-server v5 04/11] qmp helpers: allow passing structured args via qemu_objectadd() Christoph Heiss
2025-07-30 9:45 ` [pve-devel] [PATCH qemu-server v5 05/11] api2: qemu: add module exposing node migration capabilities Christoph Heiss
2025-07-30 9:45 ` [pve-devel] [PATCH qemu-server v5 06/11] fix #5180: dbus-vmstate: add daemon for QEMUs dbus-vmstate interface Christoph Heiss
2025-07-30 9:45 ` [pve-devel] [PATCH qemu-server v5 07/11] fix #5180: migrate: integrate helper for live-migrating conntrack info Christoph Heiss
2025-07-30 9:45 ` Christoph Heiss [this message]
2025-07-30 9:45 ` [pve-devel] [PATCH manager v5 09/11] api2: capabilities: expose new qemu/migration endpoint Christoph Heiss
2025-07-30 9:45 ` [pve-devel] [PATCH manager v5 10/11] ui: window: Migrate: add checkbox for migrating VM conntrack state Christoph Heiss
2025-07-30 9:45 ` [pve-devel] [PATCH docs v5 11/11] qm: document conntrack state migration for live migrations Christoph Heiss
2025-07-30 23:48 ` [pve-devel] applied: " Thomas Lamprecht
2025-07-30 22:45 ` [pve-devel] applied-series: [PATCH firewall/qemu-server/manager/docs v5 00/11] fix #5180: migrate conntrack state on live migration Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250730094549.263805-9-c.heiss@proxmox.com \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox