From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH storage v2 2/5] lvm plugin: fix typo in rebase log message
Date: Tue, 29 Jul 2025 13:53:17 +0200 [thread overview]
Message-ID: <20250729115320.579286-3-f.gruenbichler@proxmox.com> (raw)
In-Reply-To: <20250729115320.579286-1-f.gruenbichler@proxmox.com>
this was copied over from Plugin.pm
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
---
src/PVE/Storage/LVMPlugin.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm
index c1f5474..5a84e82 100644
--- a/src/PVE/Storage/LVMPlugin.pm
+++ b/src/PVE/Storage/LVMPlugin.pm
@@ -1120,7 +1120,6 @@ sub volume_snapshot_delete {
my $parentpath = $snapshots->{$parentsnap}->{file};
print
"$volname: deleting snapshot '$snap' by rebasing '$childsnap' on top of '$parentsnap'\n";
- print "running 'qemu-img rebase -b $parentpath -F qcow -f qcow2 $childpath'\n";
$cmd = [
'/usr/bin/qemu-img',
'rebase',
@@ -1132,6 +1131,7 @@ sub volume_snapshot_delete {
'qcow2',
$childpath,
];
+ print "running '", join(' ', $cmd->@*), "'\n";
eval { run_command($cmd) };
if ($@) {
#in case of abort, the state of the snap is still clean, just a little bit bigger
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-29 11:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 11:53 [pve-devel] [PATCH storage/qemu-server v2 0/5] avoid absolute qcow2 references Fabian Grünbichler
2025-07-29 11:53 ` [pve-devel] [PATCH storage v2 1/5] plugin: fix typo in rebase log message Fabian Grünbichler
2025-07-29 12:04 ` Fiona Ebner
2025-07-29 12:15 ` Fabian Grünbichler
2025-07-29 11:53 ` Fabian Grünbichler [this message]
2025-07-29 11:53 ` [pve-devel] [PATCH storage v2 3/5] plugin: use relative path for qcow2 rebase command Fabian Grünbichler
2025-07-29 11:53 ` [pve-devel] [PATCH storage v2 4/5] lvm " Fabian Grünbichler
2025-07-29 11:53 ` [pve-devel] [PATCH qemu-server v2 5/5] blockdev-stream/-commit: make backing file relative Fabian Grünbichler
2025-07-29 12:51 ` [pve-devel] applied-series: [PATCH storage/qemu-server v2 0/5] avoid absolute qcow2 references Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250729115320.579286-3-f.gruenbichler@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox