public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Friedrich Weber <f.weber@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH http-server 1/1] api server: proxy config: read MAX_WORKERS integer key
Date: Tue, 29 Jul 2025 13:34:46 +0200	[thread overview]
Message-ID: <20250729113523.72332-2-f.weber@proxmox.com> (raw)
In-Reply-To: <20250729113523.72332-1-f.weber@proxmox.com>

Read the MAX_WORKERS value in /etc/default/<proxyname>. If it is not
an integer, ignore and warn.

Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
---
 src/PVE/APIServer/Utils.pm | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/PVE/APIServer/Utils.pm b/src/PVE/APIServer/Utils.pm
index 1430c98..f2c4892 100644
--- a/src/PVE/APIServer/Utils.pm
+++ b/src/PVE/APIServer/Utils.pm
@@ -28,6 +28,7 @@ sub read_proxy_config {
     $shcmd .= 'echo \"DISABLE_TLS_1_3:\$DISABLE_TLS_1_3\";';
     $shcmd .= 'echo \"PROXY_REAL_IP_HEADER:\$PROXY_REAL_IP_HEADER\";';
     $shcmd .= 'echo \"PROXY_REAL_IP_ALLOW_FROM:\$PROXY_REAL_IP_ALLOW_FROM\";';
+    $shcmd .= 'echo \"MAX_WORKERS:\$MAX_WORKERS\";';
 
     my $data = -f $conffile ? `bash -c "$shcmd"` : '';
 
@@ -77,6 +78,12 @@ sub read_proxy_config {
                 push @$ips, Net::IP->new(normalize_v4_in_v6($ip)) || die Net::IP::Error() . "\n";
             }
             $res->{$key} = $ips;
+        } elsif ($key eq 'MAX_WORKERS') {
+            if ($value =~ /^\d+$/) {
+                $res->{$key} = int($value);
+            } else {
+                warn "MAX_WORKERS specified in $conffile is not an integer: $value\n";
+            }
         } elsif (grep { $key eq $_ } @$boolean_options) {
             die "unknown value '$value' - use 0 or 1\n" if $value !~ m/^(0|1)$/;
             $res->{$key} = $value;
-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2025-07-29 11:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-29 11:34 [pve-devel] [RFC http-server/manager 0/3] fix #5392: pveproxy, pvedaemon: make number of worker processes configurable Friedrich Weber
2025-07-29 11:34 ` Friedrich Weber [this message]
2025-07-29 11:44   ` [pve-devel] [PATCH http-server 1/1] api server: proxy config: read MAX_WORKERS integer key Thomas Lamprecht
2025-07-29 15:53     ` Friedrich Weber
2025-07-29 11:34 ` [pve-devel] [PATCH manager 1/2] partially fix #5392: pveproxy: make number of workers configurable Friedrich Weber
2025-07-29 11:34 ` [pve-devel] [PATCH manager 2/2] partially fix #5392: pvedaemon: " Friedrich Weber
2025-07-29 15:54 ` [pve-devel] superseded: [RFC http-server/manager 0/3] fix #5392: pveproxy, pvedaemon: make number of worker processes configurable Friedrich Weber
2025-07-29 15:50 [pve-devel] [PATCH docs/http-server/manager 0/4] " Friedrich Weber
2025-07-29 15:50 ` [pve-devel] [PATCH http-server 1/1] api server: proxy config: read MAX_WORKERS integer key Friedrich Weber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250729113523.72332-2-f.weber@proxmox.com \
    --to=f.weber@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal