From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-manager 2/2] network-interface-pinning: do not generate link files for vfs
Date: Tue, 22 Jul 2025 16:52:23 +0200 [thread overview]
Message-ID: <20250722145223.351778-3-s.hanreich@proxmox.com> (raw)
In-Reply-To: <20250722145223.351778-1-s.hanreich@proxmox.com>
Since the renaming of virtual functions is now handled dynamically via
a custom udev rule, proxmox-network-interface-pinning needs to
additionally filter all existing virtual functions when pinning
network interface names, since otherwise they would also get a pinned
name.
Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
PVE/CLI/proxmox_network_interface_pinning.pm | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/PVE/CLI/proxmox_network_interface_pinning.pm b/PVE/CLI/proxmox_network_interface_pinning.pm
index 382e2d94b..01b94af2a 100644
--- a/PVE/CLI/proxmox_network_interface_pinning.pm
+++ b/PVE/CLI/proxmox_network_interface_pinning.pm
@@ -304,12 +304,19 @@ sub get_ip_link_mac {
return $ip_link->{link_info}->{info_slave_data}->{perm_hwaddr} // $ip_link->{address};
}
+sub iface_is_vf {
+ my ($iface_name) = @_;
+
+ return -l "/sys/class/net/$iface_name/device/physfn";
+}
+
sub get_ip_links {
my $ip_links = PVE::Network::ip_link_details();
for my $iface_name (keys $ip_links->%*) {
delete $ip_links->{$iface_name}
- if !PVE::Network::ip_link_is_physical($ip_links->{$iface_name});
+ if !PVE::Network::ip_link_is_physical($ip_links->{$iface_name})
+ || iface_is_vf($iface_name);
}
return $ip_links;
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-22 14:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 14:52 [pve-devel] [PATCH manager 0/2] add virtual function support to network-interface-pinning Stefan Hanreich
2025-07-22 14:52 ` [pve-devel] [PATCH pve-manager 1/2] configs: add udev helper for pinning virtual function names Stefan Hanreich
2025-07-22 14:52 ` Stefan Hanreich [this message]
2025-07-23 17:31 ` [pve-devel] applied: [PATCH manager 0/2] add virtual function support to network-interface-pinning Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250722145223.351778-3-s.hanreich@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox