[pve-devel] [PATCH qemu-server 1/2] ovmf: use proper drive properties for temporary efi vars drive

[pve-devel] [PATCH qemu-server 1/2] ovmf: use proper drive properties for temporary efi vars drive

[Fiona Ebner]

As reported in the community forum [0], a virtual machine using a
temporary EFI vars disk would fail to start:
> get_drive_id: no interface at /usr/share/perl5/PVE/QemuServer/Drive.pm line 864.

[0]: https://forum.proxmox.com/threads/168628/

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/QemuServer/OVMF.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/QemuServer/OVMF.pm b/src/PVE/QemuServer/OVMF.pm
index aa21c40c..9789c2fb 100644
--- a/src/PVE/QemuServer/OVMF.pm
+++ b/src/PVE/QemuServer/OVMF.pm
@@ -178,7 +178,7 @@ my sub generate_ovmf_blockdev {
         log_warn("no efidisk configured! Using temporary efivars disk.");
         my $path = "/tmp/$vmid-ovmf.fd";
         PVE::Tools::file_copy($ovmf_vars, $path, -s $ovmf_vars);
-        $drive = { file => $path };
+        $drive = { file => $path, interface => 'efidisk', index => 0 };
         $format = 'raw';
     }
 
-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH qemu-server 2/2] drive: get_drive_id: terminate error messages with newline

[Fiona Ebner]

To avoid Perl auto-attaching the line number and file.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/QemuServer/Drive.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/PVE/QemuServer/Drive.pm b/src/PVE/QemuServer/Drive.pm
index 50855ea8..9dc4e674 100644
--- a/src/PVE/QemuServer/Drive.pm
+++ b/src/PVE/QemuServer/Drive.pm
@@ -861,8 +861,8 @@ sub print_drive {
 sub get_drive_id {
     my ($drive) = @_;
 
-    die "get_drive_id: no interface" if !defined($drive->{interface});
-    die "get_drive_id: no index" if !defined($drive->{index});
+    die "get_drive_id: no interface\n" if !defined($drive->{interface});
+    die "get_drive_id: no index\n" if !defined($drive->{index});
 
     return "$drive->{interface}$drive->{index}";
 }
-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH qemu-server 1/2] ovmf: use proper drive properties for temporary efi vars drive

[Thomas Lamprecht]

On Mon, 21 Jul 2025 14:38:20 +0200, Fiona Ebner wrote:
> As reported in the community forum [0], a virtual machine using a
> temporary EFI vars disk would fail to start:
> > get_drive_id: no interface at /usr/share/perl5/PVE/QemuServer/Drive.pm line 864.
> 
> [0]: https://forum.proxmox.com/threads/168628/
> 
> 
> [...]

Applied, thanks!

[1/2] ovmf: use proper drive properties for temporary efi vars drive
      commit: c4071b74ce04b171f1087cf0bf385aa01a2e5c5d
[2/2] drive: get_drive_id: terminate error messages with newline
      commit: 47389f6f12beb2fa7a20d3c2ee70e34dc4799bf8


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel