public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: [pve-devel] [PATCH pve-manager v2 03/16] use kebab-case spelling for new SDN and firewall config-commit services
Date: Fri, 18 Jul 2025 18:26:25 +0200	[thread overview]
Message-ID: <20250718162638.444705-6-s.hanreich@proxmox.com> (raw)
In-Reply-To: <20250718162638.444705-1-s.hanreich@proxmox.com>

From: Thomas Lamprecht <t.lamprecht@proxmox.com>

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
 bin/Makefile                                                | 6 +++---
 bin/{pvefirewallcommit => pve-firewall-commit}              | 0
 bin/{pvesdncommit => pve-sdn-commit}                        | 0
 debian/postinst                                             | 2 +-
 services/Makefile                                           | 6 +++---
 ...vefirewallcommit.service => pve-firewall-commit.service} | 2 +-
 services/{pvesdncommit.service => pve-sdn-commit.service}   | 2 +-
 7 files changed, 9 insertions(+), 9 deletions(-)
 rename bin/{pvefirewallcommit => pve-firewall-commit} (100%)
 rename bin/{pvesdncommit => pve-sdn-commit} (100%)
 rename services/{pvefirewallcommit.service => pve-firewall-commit.service} (77%)
 rename services/{pvesdncommit.service => pve-sdn-commit.service} (81%)

diff --git a/bin/Makefile b/bin/Makefile
index 2d5e6f3c5..2891a663d 100644
--- a/bin/Makefile
+++ b/bin/Makefile
@@ -29,9 +29,9 @@ SCRIPTS =  			\
 
 HELPERS =			\
 	pve-startall-delay	\
-	pve-init-ceph-crash \
-	pvefirewallcommit   \
-	pvesdncommit
+	pve-init-ceph-crash	\
+	pve-firewall-commit	\
+	pve-sdn-commit
 
 MIGRATIONS =			\
 	pve-lvm-disable-autoactivation
diff --git a/bin/pvefirewallcommit b/bin/pve-firewall-commit
similarity index 100%
rename from bin/pvefirewallcommit
rename to bin/pve-firewall-commit
diff --git a/bin/pvesdncommit b/bin/pve-sdn-commit
similarity index 100%
rename from bin/pvesdncommit
rename to bin/pve-sdn-commit
diff --git a/debian/postinst b/debian/postinst
index dac40c3d8..823bedafd 100755
--- a/debian/postinst
+++ b/debian/postinst
@@ -170,7 +170,7 @@ case "$1" in
     # same as dh_systemd_enable (code copied)
 
     UNITS="pvedaemon.service pveproxy.service spiceproxy.service pvestatd.service pvebanner.service pvescheduler.service pve-daily-update.timer"
-    NO_RESTART_UNITS="pvenetcommit.service pve-guests.service pvesdncommit.service pvefirewallcommit.service"
+    NO_RESTART_UNITS="pvenetcommit.service pve-guests.service pve-sdn-commit.service pve-firewall-commit.service"
 
     for unit in ${UNITS} ${NO_RESTART_UNITS}; do
         deb-systemd-helper unmask "$unit" >/dev/null || true
diff --git a/services/Makefile b/services/Makefile
index b056c7c4d..347a6d119 100644
--- a/services/Makefile
+++ b/services/Makefile
@@ -13,9 +13,9 @@ SERVICES=			\
 	pve-storage.target	\
 	pve-daily-update.service\
 	pve-daily-update.timer	\
-	pvescheduler.service    \
-	pvesdncommit.service    \
-	pvefirewallcommit.service
+	pvescheduler.service	\
+	pve-sdn-commit.service	\
+	pve-firewall-commit.service
 
 .PHONY: install
 install: $(SERVICES)
diff --git a/services/pvefirewallcommit.service b/services/pve-firewall-commit.service
similarity index 77%
rename from services/pvefirewallcommit.service
rename to services/pve-firewall-commit.service
index 1c9a70e74..77ea095d7 100644
--- a/services/pvefirewallcommit.service
+++ b/services/pve-firewall-commit.service
@@ -5,7 +5,7 @@ Wants=pve-cluster.service
 After=pve-cluster.service
 
 [Service]
-ExecStart=/usr/share/pve-manager/helpers/pvefirewallcommit
+ExecStart=/usr/share/pve-manager/helpers/pve-firewall-commit
 Type=oneshot
 RemainAfterExit=yes
 
diff --git a/services/pvesdncommit.service b/services/pve-sdn-commit.service
similarity index 81%
rename from services/pvesdncommit.service
rename to services/pve-sdn-commit.service
index b8b8c781f..927d06c54 100644
--- a/services/pvesdncommit.service
+++ b/services/pve-sdn-commit.service
@@ -5,7 +5,7 @@ Wants=pve-cluster.service network.target
 After=frr.service network.target pve-cluster.service
 
 [Service]
-ExecStart=/usr/share/pve-manager/helpers/pvesdncommit
+ExecStart=/usr/share/pve-manager/helpers/pve-sdn-commit
 Type=oneshot
 RemainAfterExit=yes
 
-- 
2.39.5


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2025-07-18 16:26 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-18 16:26 [pve-devel] [PATCH common/manager v2 00/18] backport 'proxmox-network-interface-pinning fixes' Stefan Hanreich
2025-07-18 16:26 ` [pve-devel] [PATCH pve-common v2 1/2] network: add ip link and altname helpers Stefan Hanreich
2025-07-18 16:26 ` [pve-devel] [PATCH pve-common v2 2/2] network: add nic prefix to physical nic regex Stefan Hanreich
2025-07-18 16:26 ` [pve-devel] [PATCH pve-manager v2 01/16] cli: add proxmox-network-interface-pinning tool Stefan Hanreich
2025-07-18 16:26 ` [pve-devel] [PATCH pve-manager v2 02/16] services: add pvesdncommit and pvefirewallcommit Stefan Hanreich
2025-07-18 16:26 ` Stefan Hanreich [this message]
2025-07-18 16:26 ` [pve-devel] [PATCH pve-manager v2 04/16] firewall on-boot commit: report errors if rename fails Stefan Hanreich
2025-07-18 16:26 ` [pve-devel] [PATCH pve-manager v2 05/16] nic pinning: prompt before continuing if connected to TTY Stefan Hanreich
2025-07-18 16:26 ` [pve-devel] [PATCH pve-manager v2 06/16] nic pinning: update description for generate command Stefan Hanreich
2025-07-18 16:26 ` [pve-devel] [PATCH pve-manager v2 07/16] nic pinning: rename 'nic' parameter to 'interface' Stefan Hanreich
2025-07-18 16:26 ` [pve-devel] [PATCH pve-manager v2 08/16] nic pinning: improve some informational and error output wording/formatting Stefan Hanreich
2025-07-18 16:26 ` [pve-devel] [PATCH pve-manager v2 09/16] pve-sdn-commit: fix reloading logic Stefan Hanreich
2025-07-18 16:26 ` [pve-devel] [PATCH pve-manager v2 10/16] proxmox-network-interface-pinning: die on failing to write interfaces Stefan Hanreich
2025-07-18 16:26 ` [pve-devel] [PATCH pve-manager v2 11/16] proxmox-network-interface-pinning: fix pinning after reboot Stefan Hanreich
2025-07-18 16:26 ` [pve-devel] [PATCH pve-manager v2 12/16] network-interface-pinning: avoid comparing undefined string Stefan Hanreich
2025-07-18 16:26 ` [pve-devel] [PATCH pve-manager v2 13/16] {sdn, firewall}-commit: wait for quorum Stefan Hanreich
2025-07-18 16:26 ` [pve-devel] [PATCH pve-manager v2 14/16] sdn-commit: only reload ifupdown if sdn configuration changed Stefan Hanreich
2025-07-18 16:26 ` [pve-devel] [PATCH pve-manager v2 15/16] network-interface-pinning: fix subsequent invocations Stefan Hanreich
2025-07-18 16:26 ` [pve-devel] [PATCH pve-manager v2 16/16] network-interface-pinning: early exit if nothing to do Stefan Hanreich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250718162638.444705-6-s.hanreich@proxmox.com \
    --to=s.hanreich@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal