From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-manager 1/3] network-interface-pinning: avoid comparing undefined string
Date: Fri, 18 Jul 2025 14:33:11 +0200 [thread overview]
Message-ID: <20250718123313.208460-2-s.hanreich@proxmox.com> (raw)
In-Reply-To: <20250718123313.208460-1-s.hanreich@proxmox.com>
Controllers do not necessarily have a node defined, so check for
definedness before comparing the value to avoid ugly error messages.
Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
PVE/CLI/proxmox_network_interface_pinning.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/CLI/proxmox_network_interface_pinning.pm b/PVE/CLI/proxmox_network_interface_pinning.pm
index 271ec0430..17b507911 100644
--- a/PVE/CLI/proxmox_network_interface_pinning.pm
+++ b/PVE/CLI/proxmox_network_interface_pinning.pm
@@ -53,7 +53,7 @@ my sub update_sdn_controllers {
for my $controller (values $controllers->{ids}->%*) {
next
- if $local_node ne $controller->{node}
+ if ($controller->{node} && $local_node ne $controller->{node})
|| $controller->{type} ne 'isis';
$controller->{'isis-ifaces'} = $mapping->list($controller->{'isis-ifaces'});
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-18 12:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 12:33 [pve-devel] [PATCH manager 0/3] network interface pinning fixes Stefan Hanreich
2025-07-18 12:33 ` Stefan Hanreich [this message]
2025-07-18 12:33 ` [pve-devel] [PATCH pve-manager 2/3] {sdn, firewall}-commit: wait for quorum Stefan Hanreich
2025-07-18 12:33 ` [pve-devel] [PATCH pve-manager 3/3] sdn-commit: only reload ifupdown if sdn configuration changed Stefan Hanreich
2025-07-18 12:45 ` [pve-devel] applied: [PATCH manager 0/3] network interface pinning fixes Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250718123313.208460-2-s.hanreich@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox