public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Gabriel Goller <g.goller@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH] fabrics: add maxLength to fabric name to improve error message
Date: Fri, 18 Jul 2025 14:02:13 +0200	[thread overview]
Message-ID: <20250718120213.325141-1-g.goller@proxmox.com> (raw)

A fabric name has a character limit of 8 characters. (This is due to the
dummy interface, which is named 'dummy_<fabric_name>' which is limited
by the max interface name length in the kernel.) This shows a nicer
error message instead of only "Invalid character".

Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
 www/manager6/sdn/fabrics/FabricEdit.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/www/manager6/sdn/fabrics/FabricEdit.js b/www/manager6/sdn/fabrics/FabricEdit.js
index 5aa001564175..07d1692879c7 100644
--- a/www/manager6/sdn/fabrics/FabricEdit.js
+++ b/www/manager6/sdn/fabrics/FabricEdit.js
@@ -18,6 +18,7 @@ Ext.define('PVE.sdn.Fabric.Fabric.Edit', {
             xtype: 'proxmoxtextfield',
             fieldLabel: gettext('Name'),
             labelWidth: 120,
+            maxLength: 8,
             name: 'id',
             cbind: {
                 disabled: '{!isCreate}',
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


             reply	other threads:[~2025-07-18 12:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-18 12:02 Gabriel Goller [this message]
2025-07-18 12:10 ` Gabriel Goller
2025-07-18 12:45 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250718120213.325141-1-g.goller@proxmox.com \
    --to=g.goller@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal