public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager] ui: adapt to dropped VM.Monitor privilege
@ 2025-07-18 11:55 Fiona Ebner
  2025-07-18 12:45 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Fiona Ebner @ 2025-07-18 11:55 UTC (permalink / raw)
  To: pve-devel

Querying the VM IP requires VM.GuestAgent.Audit now and accessing the
QEMU HMP monitor requires Sys.Audit.

Reported-by: Max Carrara <m.carrara@proxmox.com>
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 www/manager6/qemu/AgentIPView.js | 4 ++--
 www/manager6/qemu/Config.js      | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/www/manager6/qemu/AgentIPView.js b/www/manager6/qemu/AgentIPView.js
index 14342cfb..f32409a9 100644
--- a/www/manager6/qemu/AgentIPView.js
+++ b/www/manager6/qemu/AgentIPView.js
@@ -137,9 +137,9 @@ Ext.define('PVE.qemu.AgentIPView', {
 
         var caps = Ext.state.Manager.get('GuiCap');
 
-        if (!caps.vms['VM.Monitor']) {
+        if (!caps.vms['VM.GuestAgent.Audit']) {
             let errorText = gettext("Requires '{0}' Privileges");
-            me.updateStatus(false, Ext.String.format(errorText, 'VM.Monitor'));
+            me.updateStatus(false, Ext.String.format(errorText, 'VM.GuestAgent.Audit'));
             return;
         }
 
diff --git a/www/manager6/qemu/Config.js b/www/manager6/qemu/Config.js
index 34ce888f..842d35de 100644
--- a/www/manager6/qemu/Config.js
+++ b/www/manager6/qemu/Config.js
@@ -345,7 +345,7 @@ Ext.define('PVE.qemu.Config', {
             },
         );
 
-        if (caps.vms['VM.Monitor'] && !template) {
+        if (caps.nodes['Sys.Audit'] && !template) {
             me.items.push({
                 title: gettext('Monitor'),
                 iconCls: 'fa fa-eye',
-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH manager] ui: adapt to dropped VM.Monitor privilege
  2025-07-18 11:55 [pve-devel] [PATCH manager] ui: adapt to dropped VM.Monitor privilege Fiona Ebner
@ 2025-07-18 12:45 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2025-07-18 12:45 UTC (permalink / raw)
  To: pve-devel, Fiona Ebner

On Fri, 18 Jul 2025 13:55:05 +0200, Fiona Ebner wrote:
> Querying the VM IP requires VM.GuestAgent.Audit now and accessing the
> QEMU HMP monitor requires Sys.Audit.
> 
> 

Applied, thanks!

[1/1] ui: adapt to dropped VM.Monitor privilege
      commit: 3fb8ce728545b4d84a08ff0558fbef873718ae82


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-07-18 12:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-07-18 11:55 [pve-devel] [PATCH manager] ui: adapt to dropped VM.Monitor privilege Fiona Ebner
2025-07-18 12:45 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal