From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] ui: adapt to dropped VM.Monitor privilege
Date: Fri, 18 Jul 2025 13:55:05 +0200 [thread overview]
Message-ID: <20250718115527.105844-1-f.ebner@proxmox.com> (raw)
Querying the VM IP requires VM.GuestAgent.Audit now and accessing the
QEMU HMP monitor requires Sys.Audit.
Reported-by: Max Carrara <m.carrara@proxmox.com>
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
www/manager6/qemu/AgentIPView.js | 4 ++--
www/manager6/qemu/Config.js | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/www/manager6/qemu/AgentIPView.js b/www/manager6/qemu/AgentIPView.js
index 14342cfb..f32409a9 100644
--- a/www/manager6/qemu/AgentIPView.js
+++ b/www/manager6/qemu/AgentIPView.js
@@ -137,9 +137,9 @@ Ext.define('PVE.qemu.AgentIPView', {
var caps = Ext.state.Manager.get('GuiCap');
- if (!caps.vms['VM.Monitor']) {
+ if (!caps.vms['VM.GuestAgent.Audit']) {
let errorText = gettext("Requires '{0}' Privileges");
- me.updateStatus(false, Ext.String.format(errorText, 'VM.Monitor'));
+ me.updateStatus(false, Ext.String.format(errorText, 'VM.GuestAgent.Audit'));
return;
}
diff --git a/www/manager6/qemu/Config.js b/www/manager6/qemu/Config.js
index 34ce888f..842d35de 100644
--- a/www/manager6/qemu/Config.js
+++ b/www/manager6/qemu/Config.js
@@ -345,7 +345,7 @@ Ext.define('PVE.qemu.Config', {
},
);
- if (caps.vms['VM.Monitor'] && !template) {
+ if (caps.nodes['Sys.Audit'] && !template) {
me.items.push({
title: gettext('Monitor'),
iconCls: 'fa fa-eye',
--
2.47.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-07-18 11:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 11:55 Fiona Ebner [this message]
2025-07-18 12:45 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250718115527.105844-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox