From: Gabriel Goller <g.goller@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: [pve-devel] [PATCH pve-manager 2/2] fabrics: add emptyText attributes to some input fields
Date: Thu, 17 Jul 2025 14:06:39 +0200 [thread overview]
Message-ID: <20250717120639.401311-2-g.goller@proxmox.com> (raw)
In-Reply-To: <20250717120639.401311-1-g.goller@proxmox.com>
Add default emptyText attributes to OpenFabric and OSPF add/edit
windows. Use the default values on Hello Interval [0], CSNP Interval [1]
and Hello Multiplier [2] inputs. For the OSPF area just use the simplest
area "0" (the backbone).
[0]: https://github.com/FRRouting/frr/blob/f56119ea0321ee7d149172422a6d87e106a94778/isisd/isis_constants.h#L77
[1]: https://github.com/FRRouting/frr/blob/f56119ea0321ee7d149172422a6d87e106a94778/isisd/isis_constants.h#L69
[2]: https://github.com/FRRouting/frr/blob/f56119ea0321ee7d149172422a6d87e106a94778/isisd/isis_constants.h#L81
Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
www/manager6/sdn/fabrics/openfabric/FabricEdit.js | 2 ++
www/manager6/sdn/fabrics/openfabric/InterfacePanel.js | 1 +
www/manager6/sdn/fabrics/ospf/FabricEdit.js | 1 +
3 files changed, 4 insertions(+)
diff --git a/www/manager6/sdn/fabrics/openfabric/FabricEdit.js b/www/manager6/sdn/fabrics/openfabric/FabricEdit.js
index 9da624190bc6..46dd61c410aa 100644
--- a/www/manager6/sdn/fabrics/openfabric/FabricEdit.js
+++ b/www/manager6/sdn/fabrics/openfabric/FabricEdit.js
@@ -47,6 +47,7 @@ Ext.define('PVE.sdn.Fabric.OpenFabric.Fabric.Edit', {
labelWidth: 120,
name: 'hello_interval',
allowBlank: true,
+ emptyText: '3',
skipEmptyText: true,
cbind: {
deleteEmpty: '{!isCreate}',
@@ -58,6 +59,7 @@ Ext.define('PVE.sdn.Fabric.OpenFabric.Fabric.Edit', {
labelWidth: 120,
name: 'csnp_interval',
allowBlank: true,
+ emptyText: '10',
skipEmptyText: true,
cbind: {
deleteEmpty: '{!isCreate}',
diff --git a/www/manager6/sdn/fabrics/openfabric/InterfacePanel.js b/www/manager6/sdn/fabrics/openfabric/InterfacePanel.js
index fbc2a27d8c9e..f23b889b4687 100644
--- a/www/manager6/sdn/fabrics/openfabric/InterfacePanel.js
+++ b/www/manager6/sdn/fabrics/openfabric/InterfacePanel.js
@@ -24,6 +24,7 @@ Ext.define('PVE.sdn.Fabric.OpenFabric.InterfacePanel', {
widget: {
xtype: 'proxmoxintegerfield',
isFormField: false,
+ emptyText: '10',
bind: {
disabled: '{record.isDisabled}',
},
diff --git a/www/manager6/sdn/fabrics/ospf/FabricEdit.js b/www/manager6/sdn/fabrics/ospf/FabricEdit.js
index c27c6eb4458d..4c4e17c99090 100644
--- a/www/manager6/sdn/fabrics/ospf/FabricEdit.js
+++ b/www/manager6/sdn/fabrics/ospf/FabricEdit.js
@@ -14,6 +14,7 @@ Ext.define('PVE.sdn.Fabric.Ospf.Fabric.Edit', {
fieldLabel: gettext('Area'),
labelWidth: 120,
name: 'area',
+ emptyText: '0',
allowBlank: false,
},
],
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-17 12:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-17 12:06 [pve-devel] [PATCH pve-manager 1/2] fabric: increase width of fabric edit/add window Gabriel Goller
2025-07-17 12:06 ` Gabriel Goller [this message]
2025-07-17 21:28 ` [pve-devel] applied-series: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250717120639.401311-2-g.goller@proxmox.com \
--to=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox