public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-common v3 1/2] network: add ip link and altname helpers
Date: Wed, 16 Jul 2025 18:39:03 +0200	[thread overview]
Message-ID: <20250716163911.406995-2-s.hanreich@proxmox.com> (raw)
In-Reply-To: <20250716163911.406995-1-s.hanreich@proxmox.com>

Those helpers will be used by several other packages to implement the
altname support. Those helpers will also be used by the new
proxmox-network-interface-pinning tool which can be used for pinning
interface names.

Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
 src/PVE/Network.pm | 45 +++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/src/PVE/Network.pm b/src/PVE/Network.pm
index d084b36..ce87b93 100644
--- a/src/PVE/Network.pm
+++ b/src/PVE/Network.pm
@@ -973,4 +973,49 @@ sub is_ovs_bridge {
     die "failed to query OVS to determine type of '$bridge': $res\n";
 }
 
+sub ip_link_details {
+    my $link_json = '';
+
+    PVE::Tools::run_command(
+        ['ip', '-details', '-json', 'link', 'show'],
+        outfunc => sub {
+            $link_json .= shift;
+        }
+    );
+
+    my $links = JSON::decode_json($link_json);
+    my %ip_links = map { $_->{ifname} => $_ } $links->@*;
+
+    return \%ip_links;
+}
+
+sub ip_link_is_physical {
+    my ($ip_link) = @_;
+
+    # ether alone isn't enough, as virtual interfaces can also have link_type
+    # ether
+    return $ip_link->{link_type} eq 'ether'
+        && (!defined($ip_link->{linkinfo}) || !defined($ip_link->{linkinfo}->{info_kind}));
+}
+
+sub altname_mapping {
+    my ($ip_links) = @_;
+
+    $ip_links = ip_link_details() if !defined($ip_links);
+
+    my $altnames = {};
+
+    foreach my $iface_name (keys $ip_links->%*) {
+        my $iface = $ip_links->{$iface_name};
+
+        next if !$iface->{altnames};
+
+        foreach my $altname ($iface->{altnames}->@*) {
+            $altnames->{$altname} = $iface_name;
+        }
+    }
+
+    return $altnames;
+}
+
 1;
-- 
2.39.5


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2025-07-16 16:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-16 16:39 [pve-devel] [RFC common/docs/firewall/manager/network/proxmox{-ve-rs, -firewall} v3 0/9] NIC renaming mitigations Stefan Hanreich
2025-07-16 16:39 ` Stefan Hanreich [this message]
2025-07-16 16:39 ` [pve-devel] [PATCH pve-common v3 2/2] network: add nic prefix to physical nic regex Stefan Hanreich
2025-07-16 16:39 ` [pve-devel] [PATCH proxmox-ve-rs v3 1/1] config: ip link struct Stefan Hanreich
2025-07-16 16:39 ` [pve-devel] [PATCH proxmox-firewall v3 1/1] firewall: add altname support for firewall rules Stefan Hanreich
2025-07-16 16:39 ` [pve-devel] [PATCH pve-firewall v3 1/1] firewall: add altname support Stefan Hanreich
2025-07-16 16:39 ` [pve-devel] [PATCH pve-network v3 1/1] controllers: isis: " Stefan Hanreich
2025-07-16 16:39 ` [pve-devel] [PATCH pve-manager v3 1/2] cli: add proxmox-network-interface-pinning tool Stefan Hanreich
2025-07-16 16:39 ` [pve-devel] [PATCH pve-manager v3 2/2] services: add pvesdncommit and pvefirewallcommit Stefan Hanreich
2025-07-16 16:39 ` [pve-devel] [PATCH pve-docs v3 1/1] network: add documentation for proxmox-network-interface-pinning Stefan Hanreich
2025-07-16 17:49 ` [pve-devel] applied-series: [RFC common/docs/firewall/manager/network/proxmox{-ve-rs, -firewall} v3 0/9] NIC renaming mitigations Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250716163911.406995-2-s.hanreich@proxmox.com \
    --to=s.hanreich@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal