[pve-devel] [PATCH installer 0/3] run env, auto: fix dhcp hostname/domain retrieval

[Christoph Heiss <c.heiss@proxmox.com>]

First two patches fix two small, separate issues w.r.t. the automatic
retrieval of hostname and search domain from the DHCP lease.

First one is a correctness fix for RFC 2132, which specifies that the
hostname in the DHCP lease _can_ also contain a fully-qualified name,
i.e. <hostname>.<domain>. That can easily be stripped.

Second was that in the auto-installer answer file `global.fqdn.domain`
can be set to an empty string, which further down the line causes
parsing failure and the default `<productname>.example.invalid` being
set as system FQDN.

Both were reported by a user on the community forum [0].

Third patch just runs perltidy on the codebase again, fixing up some
recent changes.

[0] https://forum.proxmox.com/threads/auto-install-fetching-fqdn-through-dhcp-does-not-set-search-domain-correctly.168369/

Diffstat
========

Christoph Heiss (3):
  run env: fix dhcp-set hostname containing local domain
  auto: answer: deserialize empty domain name as `None`
  install: run `make tidy`

 Proxmox/Install.pm                            |  6 ++++--
 Proxmox/Install/RunEnv.pm                     |  8 +++++++-
 Proxmox/Sys/Net.pm                            | 12 ++++++++----
 proxmox-auto-installer/src/answer.rs          | 13 +++++++++++++
 proxmox-auto-installer/tests/parse-answer.rs  |  1 +
 ...n_from_dhcp_empty_dhcp_domain_setting.json | 19 +++++++++++++++++++
 ...n_from_dhcp_empty_dhcp_domain_setting.toml | 17 +++++++++++++++++
 7 files changed, 69 insertions(+), 7 deletions(-)
 create mode 100644 proxmox-auto-installer/tests/resources/parse_answer/fqdn_from_dhcp_empty_dhcp_domain_setting.json
 create mode 100644 proxmox-auto-installer/tests/resources/parse_answer/fqdn_from_dhcp_empty_dhcp_domain_setting.toml

-- 
2.49.0


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel