From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager v3 1/2] ui: remove handling of obsolete notification-policy/target settings
Date: Wed, 9 Jul 2025 10:14:31 +0200 [thread overview]
Message-ID: <20250709081432.91868-2-l.wagner@proxmox.com> (raw)
In-Reply-To: <20250709081432.91868-1-l.wagner@proxmox.com>
These were only used in the 'old' revamped notification stack which was
briefly available on pvetest. With PVE 9 we can finally get completely
rid of these.
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
Reviewed-by: Michael Köppl <m.koeppl@proxmox.com>
Tested-by: Michael Köppl <m.koeppl@proxmox.com>
---
Notes:
Changes since v1:
- Rebased onto latest master (PVE 9)
www/manager6/dc/Backup.js | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index 3808aa25..5eb8b5fb 100644
--- a/www/manager6/dc/Backup.js
+++ b/www/manager6/dc/Backup.js
@@ -37,14 +37,6 @@ Ext.define('PVE.dc.BackupEdit', {
delete values.node;
}
- // Get rid of new-old parameters for notification settings.
- // These should only be set for those selected few who ran
- // pve-manager from pvetest.
- if (!isCreate) {
- Proxmox.Utils.assemble_field_data(values, { delete: 'notification-policy' });
- Proxmox.Utils.assemble_field_data(values, { delete: 'notification-target' });
- }
-
let selMode = values.selMode;
delete values.selMode;
@@ -158,14 +150,6 @@ Ext.define('PVE.dc.BackupEdit', {
let me = this;
let viewModel = me.getViewModel();
- // Migrate 'new'-old notification-policy back to old-old mailnotification.
- // Only should affect users who used pve-manager from pvetest. This was a remnant of
- // notifications before the overhaul.
- let policy = data['notification-policy'];
- if (policy === 'always' || policy === 'failure') {
- data.mailnotification = policy;
- }
-
if (data.exclude) {
data.vmid = data.exclude;
data.selMode = 'exclude';
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-09 8:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 8:14 [pve-devel] [PATCH pve-guest-common v3 1/1] backup job: remove 'notification-policy' and 'notification-target' options Lukas Wagner
2025-07-09 8:14 ` Lukas Wagner [this message]
2025-07-11 12:34 ` [pve-devel] applied: [PATCH manager v3 1/2] ui: remove handling of obsolete notification-policy/target settings Thomas Lamprecht
2025-07-09 8:14 ` [pve-devel] [PATCH manager v3 2/2] ui: backup job details: show notification-mode instead of legacy keys Lukas Wagner
2025-07-11 12:34 ` [pve-devel] applied: " Thomas Lamprecht
2025-07-11 15:04 ` [pve-devel] " Gabriel Goller
2025-07-14 7:26 ` Lukas Wagner
2025-07-14 8:30 ` Gabriel Goller
2025-07-14 8:42 ` Lukas Wagner
2025-07-15 19:59 ` Thomas Lamprecht
2025-07-16 9:11 ` Lukas Wagner
2025-07-11 12:34 ` [pve-devel] applied: [PATCH pve-guest-common v3 1/1] backup job: remove 'notification-policy' and 'notification-target' options Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250709081432.91868-2-l.wagner@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox