public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-guest-common v3 1/1] backup job: remove 'notification-policy' and 'notification-target' options
Date: Wed,  9 Jul 2025 10:14:30 +0200	[thread overview]
Message-ID: <20250709081432.91868-1-l.wagner@proxmox.com> (raw)

Those were only used in the first iteration of the new notification
stack, which unfortunately hit pvetest too soon. These two keys have no
effect and were proactively removed by the GUI when changing
backup job settings.

With the major update to PVE 9 these can finally be dropped. The pve8to9
script will gain a check to check for any left-over keys.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
Tested-by: Michael Köppl <m.koeppl@proxmox.com>
Reviewed-by: Michael Köppl <m.koeppl@proxmox.com>
---

Notes:
    Changes since v1:
      - rebase onto latest master

 src/PVE/VZDump/Common.pm | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm
index 37f5509..902829f 100644
--- a/src/PVE/VZDump/Common.pm
+++ b/src/PVE/VZDump/Common.pm
@@ -266,19 +266,6 @@ my $confdesc = {
         enum => ['auto', 'legacy-sendmail', 'notification-system'],
         default => 'auto',
     },
-    'notification-policy' => {
-        type => 'string',
-        description => "Deprecated: Do not use",
-        optional => 1,
-        enum => ['always', 'failure', 'never'],
-        default => 'always',
-    },
-    'notification-target' => {
-        type => 'string',
-        format => 'pve-configid',
-        description => "Deprecated: Do not use",
-        optional => 1,
-    },
     tmpdir => {
         type => 'string',
         description => "Store temporary files to specified directory.",
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

             reply	other threads:[~2025-07-09  8:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-09  8:14 Lukas Wagner [this message]
2025-07-09  8:14 ` [pve-devel] [PATCH manager v3 1/2] ui: remove handling of obsolete notification-policy/target settings Lukas Wagner
2025-07-11 12:34   ` [pve-devel] applied: " Thomas Lamprecht
2025-07-09  8:14 ` [pve-devel] [PATCH manager v3 2/2] ui: backup job details: show notification-mode instead of legacy keys Lukas Wagner
2025-07-11 12:34   ` [pve-devel] applied: " Thomas Lamprecht
2025-07-11 15:04   ` [pve-devel] " Gabriel Goller
2025-07-14  7:26     ` Lukas Wagner
2025-07-14  8:30       ` Gabriel Goller
2025-07-14  8:42         ` Lukas Wagner
2025-07-15 19:59           ` Thomas Lamprecht
2025-07-16  9:11             ` Lukas Wagner
2025-07-11 12:34 ` [pve-devel] applied: [PATCH pve-guest-common v3 1/1] backup job: remove 'notification-policy' and 'notification-target' options Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250709081432.91868-1-l.wagner@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal