public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH installer v2 1/2] auto: answer: drop unneeded #[serde(default)] attributes
Date: Mon,  7 Jul 2025 12:08:13 +0200	[thread overview]
Message-ID: <20250707100830.550898-2-c.heiss@proxmox.com> (raw)
In-Reply-To: <20250707100830.550898-1-c.heiss@proxmox.com>

For `Option<>`s, serde automatically defaults to `None` for
deserialization in case the key is missing in the source.

No functional changes.

Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
Changes v1 -> v2:
  * no changes

 proxmox-auto-installer/src/answer.rs | 2 --
 1 file changed, 2 deletions(-)

diff --git a/proxmox-auto-installer/src/answer.rs b/proxmox-auto-installer/src/answer.rs
index aafe38f..c500933 100644
--- a/proxmox-auto-installer/src/answer.rs
+++ b/proxmox-auto-installer/src/answer.rs
@@ -22,9 +22,7 @@ pub struct Answer {
     pub network: Network,
     #[serde(rename = "disk-setup")]
     pub disks: Disks,
-    #[serde(default)]
     pub post_installation_webhook: Option<PostNotificationHookInfo>,
-    #[serde(default)]
     pub first_boot: Option<FirstBootHookInfo>,
 }
 
-- 
2.49.0



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2025-07-07 10:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-07 10:08 [pve-devel] [PATCH installer v2 0/2] auto: answer: answer file serde cleanups Christoph Heiss
2025-07-07 10:08 ` Christoph Heiss [this message]
2025-07-07 10:08 ` [pve-devel] [PATCH installer v2 2/2] auto: answer: simplify `BTreeMap` handling in deserialization Christoph Heiss
2025-07-07 12:40 ` [pve-devel] applied-series: [PATCH installer v2 0/2] auto: answer: answer file serde cleanups Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250707100830.550898-2-c.heiss@proxmox.com \
    --to=c.heiss@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal