From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH ha-manager v3 3/6] watchdog-mux: warn when about to expire
Date: Fri, 4 Jul 2025 15:38:59 +0200 [thread overview]
Message-ID: <20250704133902.398663-4-m.sandoval@proxmox.com> (raw)
In-Reply-To: <20250704133902.398663-1-m.sandoval@proxmox.com>
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
src/watchdog-mux.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/src/watchdog-mux.c b/src/watchdog-mux.c
index 2b8cebf..0518e86 100644
--- a/src/watchdog-mux.c
+++ b/src/watchdog-mux.c
@@ -30,15 +30,23 @@
#define JOURNALCTL_BIN "/bin/journalctl"
#define CLIENT_WATCHDOG_TIMEOUT 60
+#define CLIENT_WATCHDOG_TIMEOUT_WARNING (CLIENT_WATCHDOG_TIMEOUT - 10)
int watchdog_fd = -1;
int watchdog_timeout = 10;
int update_watchdog = 1;
+enum warning_state_t {
+ NONE,
+ WARNING_ISSUED,
+ FENCE_AVERTED,
+};
+
typedef struct {
int fd;
time_t time;
int magic_close;
+ enum warning_state_t warning_state;
} wd_client_t;
#define MAX_CLIENTS 100
@@ -53,6 +61,7 @@ static wd_client_t *alloc_client(int fd, time_t time) {
client_list[i].fd = fd;
client_list[i].time = time;
client_list[i].magic_close = 0;
+ client_list[i].warning_state = NONE;
return &client_list[i];
}
}
@@ -235,6 +244,18 @@ int main(void) {
time_t ctime = time(NULL);
for (i = 0; i < MAX_CLIENTS; i++) {
if (client_list[i].fd != 0 && client_list[i].time != 0) {
+ if (client_list[i].warning_state == WARNING_ISSUED &&
+ (ctime - client_list[i].time) <= CLIENT_WATCHDOG_TIMEOUT_WARNING) {
+ client_list[i].warning_state = FENCE_AVERTED;
+ fprintf(stderr, "client watchdog was updated before expiring\n");
+ }
+
+ if (client_list[i].warning_state != WARNING_ISSUED &&
+ (ctime - client_list[i].time) > CLIENT_WATCHDOG_TIMEOUT_WARNING) {
+ client_list[i].warning_state = WARNING_ISSUED;
+ fprintf(stderr, "client watchdog is about to expire\n");
+ }
+
if ((ctime - client_list[i].time) > CLIENT_WATCHDOG_TIMEOUT) {
update_watchdog = 0;
fprintf(stderr, "client watchdog expired - disable watchdog updates\n");
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-04 13:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-04 13:38 [pve-devel] [PATCH ha-manager v3 0/6] watchdog-mux: sync log to disk before and after expiring Maximiliano Sandoval
2025-07-04 13:38 ` [pve-devel] [PATCH ha-manager v3 1/6] watchdog-mux: Use #define for 60s timeout Maximiliano Sandoval
2025-07-04 13:38 ` [pve-devel] [PATCH ha-manager v3 2/6] watchdog-mux: split if block in two if blocks Maximiliano Sandoval
2025-07-04 13:38 ` Maximiliano Sandoval [this message]
2025-07-04 13:39 ` [pve-devel] [PATCH ha-manager v3 4/6] watchdog-mux: sync journal right after fence warning Maximiliano Sandoval
2025-07-04 13:39 ` [pve-devel] [PATCH ha-manager v3 5/6] watchdog-mux: break out of loop when updates are disabled Maximiliano Sandoval
2025-07-04 13:39 ` [pve-devel] [PATCH ha-manager v3 6/6] watchdog-mux: Remove wrapping if guard Maximiliano Sandoval
2025-07-17 16:00 ` [pve-devel] applied: [PATCH ha-manager v3 0/6] watchdog-mux: sync log to disk before and after expiring Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250704133902.398663-4-m.sandoval@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox