From: "Michael Köppl" <m.koeppl@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server v8 3/4] destroy_vm: use log_warn for vdisk_free errors for consistency
Date: Thu, 26 Jun 2025 18:06:25 +0200 [thread overview]
Message-ID: <20250626160626.311407-10-m.koeppl@proxmox.com> (raw)
In-Reply-To: <20250626160626.311407-1-m.koeppl@proxmox.com>
To make warnings visually consistent with the handling of other storage
errors in destroy_vm(), replace the use of warn with log_warn.
Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
src/PVE/QemuServer.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
index 91b0d1e0..27b4093b 100644
--- a/src/PVE/QemuServer.pm
+++ b/src/PVE/QemuServer.pm
@@ -1921,7 +1921,7 @@ sub destroy_vm {
$volids->{$volid} = 1;
eval { PVE::Storage::vdisk_free($storecfg, $volid) };
- warn "Could not remove disk '$volid', check manually: $@" if $@;
+ log_warn("Could not remove disk '$volid', check manually: $@") if $@;
};
# only remove disks owned by this VM (referenced in the config)
@@ -1947,7 +1947,7 @@ sub destroy_vm {
sub {
my ($volid, $sid, $volname, $d) = @_;
eval { PVE::Storage::vdisk_free($storecfg, $volid) };
- warn $@ if $@;
+ log_warn($@) if $@;
},
);
}
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-06-26 16:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 16:06 [pve-devel] [PATCH container/qemu-server/storage v8 00/10] fix #3711 and adapt drive detach/remove behavior Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH storage v8 1/2] vdisk_free: print warning if underlying storage does not exist Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH storage v8 2/2] parse_volname: print warning if storage does not exists Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH container v8 1/4] fix #3711: warn about storage errors during mountpoint delete Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH container v8 2/4] destroy_lxc, delete_mp_volume: rename $volume to $volid Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH container v8 3/4] config: ensure valid volid through parse_volume() Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH container v8 4/4] add linked clone check when destroying container template Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH qemu-server v8 1/4] adapt linked clone check to not die if an error occurs during check Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH qemu-server v8 2/4] fix #3711: make removal of VM possible if store does not exist anymore Michael Köppl
2025-06-26 16:06 ` Michael Köppl [this message]
2025-06-26 16:06 ` [pve-devel] [PATCH qemu-server v8 4/4] display warnings for storage errors or if storage no longer exists Michael Köppl
2025-07-08 11:09 ` [pve-devel] [PATCH container/qemu-server/storage v8 00/10] fix #3711 and adapt drive detach/remove behavior Lukas Wagner
2025-07-15 16:29 ` Michael Köppl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250626160626.311407-10-m.koeppl@proxmox.com \
--to=m.koeppl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox