[pve-devel] [PATCH qemu-server 04/15] helpers: fix perlcritic warning about variables named $a and $b

[Fiona Ebner <f.ebner@proxmox.com>]

> Using $a or $b outside sort() at line 193, column 13.  $a and $b are
> special package variables for use in sort() and related functions.
> Declaring them as lexicals like "my $a" may break sort(). Use
> different variable names.  (Severity: 4)

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/QemuServer/Helpers.pm | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/PVE/QemuServer/Helpers.pm b/src/PVE/QemuServer/Helpers.pm
index 81cc9022..9ec989f7 100644
--- a/src/PVE/QemuServer/Helpers.pm
+++ b/src/PVE/QemuServer/Helpers.pm
@@ -190,12 +190,12 @@ sub version_cmp {
     }
 
     for (my $i = 0; $i < $size; $i += 2) {
-        my ($a, $b) = splice(@versions, 0, 2);
-        $a //= 0;
-        $b //= 0;
+        my ($left, $right) = splice(@versions, 0, 2);
+        $left //= 0;
+        $right //= 0;
 
-        return 1 if $a > $b;
-        return -1 if $a < $b;
+        return 1 if $left > $right;
+        return -1 if $left < $right;
     }
     return 0;
 }
-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel