From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager v2 3/3] ui: oneshot backup: stop shifting UI when selecting 'legacy-sendmail'
Date: Tue, 17 Jun 2025 10:44:48 +0200 [thread overview]
Message-ID: <20250617084448.87536-3-l.wagner@proxmox.com> (raw)
In-Reply-To: <20250617084448.87536-1-l.wagner@proxmox.com>
The 'protected' checkbox in the left column seems to use slightly less
space than the 'mailto' field in the same row in the right column.
The 'mailto' field is only shown when the 'notification-mode' is set to
legacy-sendmail. Due to the differences in size, the UI shifts by a
couple pixels when the additional field is shown.
As a workaround, the checkbox is padded on the bottom by a tiny amount,
stopping the UI from shifting around when the additional field is
shown.
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
Notes:
New in v2.
www/manager6/window/Backup.js | 3 +++
1 file changed, 3 insertions(+)
diff --git a/www/manager6/window/Backup.js b/www/manager6/window/Backup.js
index 4377cb5f..b7021745 100644
--- a/www/manager6/window/Backup.js
+++ b/www/manager6/window/Backup.js
@@ -240,6 +240,9 @@ Ext.define('PVE.window.Backup', {
checked: false,
uncheckedValue: 0,
fieldLabel: gettext('Protected'),
+ // Tiny amount of padding to stop the UI from shifting
+ // when the 'mailto' field is shown.
+ padding: '0 0 1 0',
});
me.formPanel = Ext.create('Proxmox.panel.InputPanel', {
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-06-17 8:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 8:44 [pve-devel] [PATCH manager v2 1/3] ui: backup job edit: move notification related settings to separate tab Lukas Wagner
2025-06-17 8:44 ` [pve-devel] [PATCH manager v2 2/3] ui: one-shot backup: remove 'auto' notification mode for clarity Lukas Wagner
2025-06-17 8:44 ` Lukas Wagner [this message]
2025-06-24 12:01 ` [pve-devel] superseded: [PATCH manager v2 1/3] ui: backup job edit: move notification related settings to separate tab Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250617084448.87536-3-l.wagner@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal