public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH pve_flutter_frontend v2] fix: ui: render pending chip widget in column to avoid overflow error
@ 2025-06-16 12:58 Shan Shaji
  2025-07-01 11:55 ` [pve-devel] applied: " Dominik Csapak
  0 siblings, 1 reply; 2+ messages in thread
From: Shan Shaji @ 2025-06-16 12:58 UTC (permalink / raw)
  To: pve-devel

When the pending chip appears after enabling an option from the options
page, Flutter throws an overflow error, causing the chip to render
on top of the Switch widget due to insufficient space between
the title and the switch toggle.

To resolve this, modify the layout so that the pending chip widget
is rendered in a column instead of a row.

Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
---
 
 Steps to reproduce the issue:
 1. Navigate to the options tab of any VM.
 2. Enable the "KVM hardware viritualization" option.
 3. You will encounter a render flex error.
 
 changes since v1:
 * changed commit message. 
 * moved steps to reproduce section under "---".
 
 lib/widgets/pve_config_switch_list_tile.dart | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/widgets/pve_config_switch_list_tile.dart b/lib/widgets/pve_config_switch_list_tile.dart
index af02ee6..c209fbe 100644
--- a/lib/widgets/pve_config_switch_list_tile.dart
+++ b/lib/widgets/pve_config_switch_list_tile.dart
@@ -32,8 +32,8 @@ class PveConfigSwitchListTile extends StatelessWidget {
 
   Widget? _getTitle() {
     if (pending != null) {
-      return Row(
-        mainAxisAlignment: MainAxisAlignment.spaceBetween,
+      return Column(
+        crossAxisAlignment: CrossAxisAlignment.start,
         children: [
           title!,
           Chip(
-- 
2.39.5 (Apple Git-154)



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH pve_flutter_frontend v2] fix: ui: render pending chip widget in column to avoid overflow error
  2025-06-16 12:58 [pve-devel] [PATCH pve_flutter_frontend v2] fix: ui: render pending chip widget in column to avoid overflow error Shan Shaji
@ 2025-07-01 11:55 ` Dominik Csapak
  0 siblings, 0 replies; 2+ messages in thread
From: Dominik Csapak @ 2025-07-01 11:55 UTC (permalink / raw)
  To: pve-devel

On 6/16/25 14:58, Shan Shaji wrote:
> When the pending chip appears after enabling an option from the options
> page, Flutter throws an overflow error, causing the chip to render
> on top of the Switch widget due to insufficient space between
> the title and the switch toggle.
> 
> To resolve this, modify the layout so that the pending chip widget
> is rendered in a column instead of a row.
> 
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
>   
>   Steps to reproduce the issue:
>   1. Navigate to the options tab of any VM.
>   2. Enable the "KVM hardware viritualization" option.
>   3. You will encounter a render flex error.
>   
>   changes since v1:
>   * changed commit message.
>   * moved steps to reproduce section under "---".
>   
>   lib/widgets/pve_config_switch_list_tile.dart | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
>

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-07-01 11:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-06-16 12:58 [pve-devel] [PATCH pve_flutter_frontend v2] fix: ui: render pending chip widget in column to avoid overflow error Shan Shaji
2025-07-01 11:55 ` [pve-devel] applied: " Dominik Csapak

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal