public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Shan Shaji <s.shaji@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve_flutter_frontend v2] fix: ui: render pending chip widget in column to avoid overflow error
Date: Mon, 16 Jun 2025 14:58:44 +0200	[thread overview]
Message-ID: <20250616125844.52117-1-s.shaji@proxmox.com> (raw)

When the pending chip appears after enabling an option from the options
page, Flutter throws an overflow error, causing the chip to render
on top of the Switch widget due to insufficient space between
the title and the switch toggle.

To resolve this, modify the layout so that the pending chip widget
is rendered in a column instead of a row.

Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
---
 
 Steps to reproduce the issue:
 1. Navigate to the options tab of any VM.
 2. Enable the "KVM hardware viritualization" option.
 3. You will encounter a render flex error.
 
 changes since v1:
 * changed commit message. 
 * moved steps to reproduce section under "---".
 
 lib/widgets/pve_config_switch_list_tile.dart | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/widgets/pve_config_switch_list_tile.dart b/lib/widgets/pve_config_switch_list_tile.dart
index af02ee6..c209fbe 100644
--- a/lib/widgets/pve_config_switch_list_tile.dart
+++ b/lib/widgets/pve_config_switch_list_tile.dart
@@ -32,8 +32,8 @@ class PveConfigSwitchListTile extends StatelessWidget {
 
   Widget? _getTitle() {
     if (pending != null) {
-      return Row(
-        mainAxisAlignment: MainAxisAlignment.spaceBetween,
+      return Column(
+        crossAxisAlignment: CrossAxisAlignment.start,
         children: [
           title!,
           Chip(
-- 
2.39.5 (Apple Git-154)



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


             reply	other threads:[~2025-06-16 12:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-16 12:58 Shan Shaji [this message]
2025-07-01 11:55 ` [pve-devel] applied: " Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250616125844.52117-1-s.shaji@proxmox.com \
    --to=s.shaji@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal