[pve-devel] [PATCH guest-common] backup job: remove 'notification-policy' and 'notification-target' options

[pve-devel] [PATCH guest-common] backup job: remove 'notification-policy' and 'notification-target' options

[Lukas Wagner]

Those were only used in the first iteration of the new notification
stack, which unfortunately hit pvetest too soon. These two keys have no
effect and were proactively removed by the GUI when changing
backup job settings.

The pve8to9 script will gain a check to check for any left-over keys.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
Intended for PVE 9

 src/PVE/VZDump/Common.pm | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm
index 8fce316..f816ab0 100644
--- a/src/PVE/VZDump/Common.pm
+++ b/src/PVE/VZDump/Common.pm
@@ -230,19 +230,6 @@ my $confdesc = {
 	enum => ['auto', 'legacy-sendmail', 'notification-system'],
 	default => 'auto',
     },
-    'notification-policy' => {
-	type => 'string',
-	description => "Deprecated: Do not use",
-	optional => 1,
-	enum => [ 'always', 'failure', 'never'],
-	default => 'always',
-    },
-    'notification-target' => {
-	type => 'string',
-	format => 'pve-configid',
-	description => "Deprecated: Do not use",
-	optional => 1,
-    },
     tmpdir => {
 	type => 'string',
 	description => "Store temporary files to specified directory.",
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] superseded: [PATCH guest-common] backup job: remove 'notification-policy' and 'notification-target' options

[Lukas Wagner]

Superseded-by: 
https://lore.proxmox.com/all/20250624112817.132312-1-l.wagner@proxmox.com/T/#t

On  2025-06-12 13:06, Lukas Wagner wrote:
> Those were only used in the first iteration of the new notification
> stack, which unfortunately hit pvetest too soon. These two keys have no
> effect and were proactively removed by the GUI when changing
> backup job settings.
> 
> The pve8to9 script will gain a check to check for any left-over keys.
> 
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> Intended for PVE 9
> 
>  src/PVE/VZDump/Common.pm | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm
> index 8fce316..f816ab0 100644
> --- a/src/PVE/VZDump/Common.pm
> +++ b/src/PVE/VZDump/Common.pm
> @@ -230,19 +230,6 @@ my $confdesc = {
>  	enum => ['auto', 'legacy-sendmail', 'notification-system'],
>  	default => 'auto',
>      },
> -    'notification-policy' => {
> -	type => 'string',
> -	description => "Deprecated: Do not use",
> -	optional => 1,
> -	enum => [ 'always', 'failure', 'never'],
> -	default => 'always',
> -    },
> -    'notification-target' => {
> -	type => 'string',
> -	format => 'pve-configid',
> -	description => "Deprecated: Do not use",
> -	optional => 1,
> -    },
>      tmpdir => {
>  	type => 'string',
>  	description => "Store temporary files to specified directory.",

-- 
- Lukas



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel