From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH cluster] fix #6445: correctly set size when stat-ing symlinks
Date: Fri, 6 Jun 2025 10:50:49 +0200 [thread overview]
Message-ID: <20250606085049.127928-1-f.gruenbichler@proxmox.com> (raw)
the size of a symlink should be the length of its target, some tools like
bsdtar seem to actually rely on this information for allocating buffers..
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
Notes:
should apply to master and stable-bookworm, and can IMHO go into both..
src/pmxcfs/cfs-plug-link.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/src/pmxcfs/cfs-plug-link.c b/src/pmxcfs/cfs-plug-link.c
index d4eedfc..573db4d 100644
--- a/src/pmxcfs/cfs-plug-link.c
+++ b/src/pmxcfs/cfs-plug-link.c
@@ -55,8 +55,16 @@ static int cfs_plug_link_getattr(cfs_plug_t *plug, const char *path, struct stat
cfs_debug("enter cfs_plug_link_getattr %s", path);
+ int ret = -EACCES;
+
+ cfs_plug_link_t *lnk = (cfs_plug_link_t *)plug;
+ if (!lnk->symlink) {
+ goto ret;
+ }
+
memset(stbuf, 0, sizeof(struct stat));
+ stbuf->st_size = strlen(lnk->symlink);
if (cfs_is_quorate()) {
stbuf->st_mode = S_IFLNK | 0777;
} else {
@@ -65,7 +73,10 @@ static int cfs_plug_link_getattr(cfs_plug_t *plug, const char *path, struct stat
stbuf->st_nlink = 1;
- return 0;
+ ret = 0;
+
+ret:
+ return ret;
}
static int cfs_plug_link_readlink(cfs_plug_t *plug, const char *path, char *buf, size_t max) {
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-06-06 8:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-06 8:50 Fabian Grünbichler [this message]
2025-06-25 14:50 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250606085049.127928-1-f.gruenbichler@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox