From: Christian Ebner <c.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 1/2] ui: add dedicated form for PBS change detecton mode selector
Date: Tue, 3 Jun 2025 15:09:15 +0200 [thread overview]
Message-ID: <20250603130916.310066-3-c.ebner@proxmox.com> (raw)
In-Reply-To: <20250603130916.310066-1-c.ebner@proxmox.com>
Reduce duplicate code by merging common parts of the change detection
mode selector. Allows to control a common selector used by the
advanced options of the backup job and the window for one-shot backup
runs in one place.
No functional changes intended.
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
NOTE: Assumes repo pre-formatted with proxmox-biome to apply
www/manager6/Makefile | 1 +
www/manager6/form/PbsChangeDetectionModeSelector.js | 10 ++++++++++
www/manager6/panel/BackupAdvancedOptions.js | 8 +-------
www/manager6/window/Backup.js | 8 +-------
4 files changed, 13 insertions(+), 14 deletions(-)
create mode 100644 www/manager6/form/PbsChangeDetectionModeSelector.js
diff --git a/www/manager6/Makefile b/www/manager6/Makefile
index fdf0e816..255271c5 100644
--- a/www/manager6/Makefile
+++ b/www/manager6/Makefile
@@ -55,6 +55,7 @@ JSSRC= \
form/NotificationModeSelector.js \
form/NotificationTargetSelector.js \
form/NotificationPolicySelector.js \
+ form/PbsChangeDetectionModeSelector.js \
form/PCISelector.js \
form/PCIMapSelector.js \
form/PermPathSelector.js \
diff --git a/www/manager6/form/PbsChangeDetectionModeSelector.js b/www/manager6/form/PbsChangeDetectionModeSelector.js
new file mode 100644
index 00000000..6e55aabd
--- /dev/null
+++ b/www/manager6/form/PbsChangeDetectionModeSelector.js
@@ -0,0 +1,10 @@
+Ext.define('PVE.form.PBSChangeDetectionModeSelector', {
+ extend: 'Proxmox.form.KVComboBox',
+ alias: ['widget.pbsChangeDetectionModeSelector'],
+ deleteEmpty: true,
+ comboItems: [
+ ['__default__', 'Default'],
+ ['data', 'Data'],
+ ['metadata', 'Metadata'],
+ ],
+});
diff --git a/www/manager6/panel/BackupAdvancedOptions.js b/www/manager6/panel/BackupAdvancedOptions.js
index fe8cc3bf..32fe4de5 100644
--- a/www/manager6/panel/BackupAdvancedOptions.js
+++ b/www/manager6/panel/BackupAdvancedOptions.js
@@ -276,16 +276,10 @@ Ext.define('PVE.panel.BackupAdvancedOptions', {
{
xtype: 'pveTwoColumnContainer',
startColumn: {
- xtype: 'proxmoxKVComboBox',
+ xtype: 'pbsChangeDetectionModeSelector',
fieldLabel: gettext('PBS change detection mode'),
name: 'pbs-change-detection-mode',
- deleteEmpty: true,
value: '__default__',
- comboItems: [
- ['__default__', 'Default'],
- ['data', 'Data'],
- ['metadata', 'Metadata'],
- ],
},
endFlex: 2,
endColumn: {
diff --git a/www/manager6/window/Backup.js b/www/manager6/window/Backup.js
index 00ccce4b..d4542453 100644
--- a/www/manager6/window/Backup.js
+++ b/www/manager6/window/Backup.js
@@ -54,17 +54,11 @@ Ext.define('PVE.window.Backup', {
});
let pbsChangeDetectionModeSelector = Ext.create({
- xtype: 'proxmoxKVComboBox',
+ xtype: 'pbsChangeDetectionModeSelector',
flex: 1,
disabled: true,
name: 'pbs-change-detection-mode',
- deleteEmpty: true,
value: '__default__',
- comboItems: [
- ['__default__', 'Default'],
- ['data', 'Data'],
- ['metadata', 'Metadata'],
- ],
});
let pbsChangeDetection = Ext.create('Ext.form.FieldContainer', {
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-06-03 13:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-03 13:09 [pve-devel] [PATCH container/manager 0/3] vzdump: Switch default PBS change detection mode Christian Ebner
2025-06-03 13:09 ` [pve-devel] [PATCH container 1/1] vzdump: switch default PBS change detection mode to `metadata` Christian Ebner
2025-06-03 13:09 ` Christian Ebner [this message]
2025-06-03 13:09 ` [pve-devel] [PATCH manager 2/2] ui: switch default and extend options for PBS change detection mode Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250603130916.310066-3-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal