public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH container 1/1] vzdump: switch default PBS change detection mode to `metadata`
Date: Tue,  3 Jun 2025 15:09:14 +0200	[thread overview]
Message-ID: <20250603130916.310066-2-c.ebner@proxmox.com> (raw)
In-Reply-To: <20250603130916.310066-1-c.ebner@proxmox.com>

Since commit 58839940 ("vzdump: conditionally set PBS change
detection mode option") it is possible to perform container backups
with Proxmox Backup Server as target using additional `data` and
`metadata` modes provided by the Proxmox Backup client.

While the `metadata` mode was introduced to speed up file level
backups [0], the `legacy` mode was kept as default to not
unexpectedly change the mode for container backups.

Switch the default mode to `metadata` for the upcoming Proxmox
Virtual Environment 9 release. By explicitly setting the mode, this
is independent from the PBS client's default.

[0] https://bugzilla.proxmox.com/show_bug.cgi?id=3174

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
NOTE: Assumes repo pre-formatted with proxmox-perltidy to apply

 src/PVE/VZDump/LXC.pm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/PVE/VZDump/LXC.pm b/src/PVE/VZDump/LXC.pm
index c10a4c9..84a6e02 100644
--- a/src/PVE/VZDump/LXC.pm
+++ b/src/PVE/VZDump/LXC.pm
@@ -465,8 +465,10 @@ sub archive {
         push @$param, '--backup-type', 'ct';
         push @$param, '--backup-id', $vmid;
         push @$param, '--backup-time', $task->{backup_time};
-        push @$param, '--change-detection-mode', $opts->{"pbs-change-detection-mode"}
-            if $opts->{"pbs-change-detection-mode"};
+        push @$param, '--change-detection-mode',
+            $opts->{"pbs-change-detection-mode"}
+            ? $opts->{"pbs-change-detection-mode"}
+            : 'metadata';
 
         if (my $entries_max = $opts->{"performance"}->{"pbs-entries-max"}) {
             push $param->@*, '--entries-max', $entries_max;
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2025-06-03 13:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-03 13:09 [pve-devel] [PATCH container/manager 0/3] vzdump: Switch default PBS change detection mode Christian Ebner
2025-06-03 13:09 ` Christian Ebner [this message]
2025-06-03 13:09 ` [pve-devel] [PATCH manager 1/2] ui: add dedicated form for PBS change detecton mode selector Christian Ebner
2025-06-03 13:09 ` [pve-devel] [PATCH manager 2/2] ui: switch default and extend options for PBS change detection mode Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250603130916.310066-2-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal