From: Shan Shaji <s.shaji@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox_dart_api_client v3 1/1] fix #6409: add `default` property to `PveAccessDomainModel`
Date: Tue, 3 Jun 2025 14:20:37 +0200 [thread overview]
Message-ID: <20250603122037.158232-3-s.shaji@proxmox.com> (raw)
In-Reply-To: <20250603122037.158232-1-s.shaji@proxmox.com>
When the default property was selected inside the realm
of the web UI, the app's login page was not showing the
default realm instead, it was always showing PAM.
Add `default` property and a getter boolean that internally
checks if the realm is default. This boolean is used inside
`pve_login_form.dart`, which is part of pve_login_manager.
Also the `default` property is named as `defaultValue` as `default` is
a keyword [0] in dart.
- [0] https://dart.dev/language/keywords
Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
---
changes since v2:
* remove "This commit" from the commit message.
lib/src/models/pve_access_domain_model.dart | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/lib/src/models/pve_access_domain_model.dart b/lib/src/models/pve_access_domain_model.dart
index 81cb7a4..6298bbe 100644
--- a/lib/src/models/pve_access_domain_model.dart
+++ b/lib/src/models/pve_access_domain_model.dart
@@ -9,6 +9,11 @@ abstract class PveAccessDomainModel
String get realm;
String? get comment;
String? get tfa;
+ @BuiltValueField(wireName: 'default')
+ int? get defaultValue;
+
+ bool get isDefaultRealm => defaultValue == 1;
+
PveAccessDomainModel._();
factory PveAccessDomainModel(
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-06-03 12:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-03 12:20 [pve-devel] [PATCH proxmox{_login_manager, _dart_api_client} v3 0/2] fix #6409: login manager doesn't pre-selects default authentication realm Shan Shaji
2025-06-03 12:20 ` [pve-devel] [PATCH proxmox_login_manager v3 1/1] fix #6409: add `isDefaultRealm` check to pre-select realm in login form Shan Shaji
2025-06-03 12:20 ` Shan Shaji [this message]
2025-06-06 8:18 ` [pve-devel] [PATCH proxmox{_login_manager, _dart_api_client} v3 0/2] fix #6409: login manager doesn't pre-selects default authentication realm Michael Köppl
2025-06-17 12:32 ` Shan Shaji
2025-07-01 11:55 ` [pve-devel] applied: " Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250603122037.158232-3-s.shaji@proxmox.com \
--to=s.shaji@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal