public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Shan Shaji <s.shaji@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox{_login_manager, _dart_api_client} v3 0/2] fix #6409: login manager doesn't pre-selects default authentication realm
Date: Tue,  3 Jun 2025 14:20:35 +0200	[thread overview]
Message-ID: <20250603122037.158232-1-s.shaji@proxmox.com> (raw)

When the `default` property was selected inside the realm of the web UI,
the app's login page was not showing the default realm instead, 
it was always showing PAM.

To reproduce, follow the following steps:
on the web UI go to Datacenter -> Realms and  edit another realm than 
PAM, like PVE. There you can tick the "Default" checkbox. Now go to 
the app and try adding the domain, `PAM` will be selected as default. 

This patch series fixes the issue by adding the `default` property
to the `PveAccessDomainModel` and implementing the necessary 
check in the `_getAccessDomains` function.

History
==========

v2: https://lore.proxmox.com/pve-devel/20250526154137.116322-1-s.shaji@proxmox.com/T/#t

changes since v2:
* removed "This commit" string from commit messages. 
* fixed `StateError` in `singleWhere` function which can happen 
  when both conditions are true. 
* If a realm is already saved then that selection will have priority. 

proxmox_login_manager:

Shan Shaji (1):
  fix #6409: add `isDefaultRealm` check to pre-select realm in login
    form

 lib/proxmox_login_form.dart | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)


proxmox_dart_api_client:

Shan Shaji (1):
  fix #6409: add `default` property to `PveAccessDomainModel`

 lib/src/models/pve_access_domain_model.dart | 5 +++++
 1 file changed, 5 insertions(+)


Summary over all repositories:
  2 files changed, 8 insertions(+), 1 deletions(-)

-- 
Generated by git-murpp 0.8.1


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


             reply	other threads:[~2025-06-03 12:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-03 12:20 Shan Shaji [this message]
2025-06-03 12:20 ` [pve-devel] [PATCH proxmox_login_manager v3 1/1] fix #6409: add `isDefaultRealm` check to pre-select realm in login form Shan Shaji
2025-06-03 12:20 ` [pve-devel] [PATCH proxmox_dart_api_client v3 1/1] fix #6409: add `default` property to `PveAccessDomainModel` Shan Shaji
2025-06-06  8:18 ` [pve-devel] [PATCH proxmox{_login_manager, _dart_api_client} v3 0/2] fix #6409: login manager doesn't pre-selects default authentication realm Michael Köppl
2025-06-17 12:32   ` Shan Shaji
2025-07-01 11:55 ` [pve-devel] applied: " Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250603122037.158232-1-s.shaji@proxmox.com \
    --to=s.shaji@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal