public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pbs-devel@lists.proxmox.com, pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox-backup 1/1] restore-daemon: adapt to zpool output changes in 2.3
Date: Mon,  2 Jun 2025 11:47:56 +0200	[thread overview]
Message-ID: <20250602094756.519927-7-s.ivanov@proxmox.com> (raw)
In-Reply-To: <20250602094756.519927-1-s.ivanov@proxmox.com>

the output of `zpool import` has changed, thus our current parser
failed to find a zpool with zfs userspace in version 2.3.2.

While ZFS 2.3 introduced JSON output for many commands `zpool import`
still lacks the option [0], thus I'd postpone this adapation once all
needed zfs/zpool commands provide JSON.

the change was probably introduced in zfs upstream commit:
5137c132a ("zpool import output is not formated properly.")

[0] https://github.com/openzfs/zfs/issues/17084
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
 proxmox-restore-daemon/src/proxmox_restore_daemon/disk.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/proxmox-restore-daemon/src/proxmox_restore_daemon/disk.rs b/proxmox-restore-daemon/src/proxmox_restore_daemon/disk.rs
index 50fbf315..e068ab9b 100644
--- a/proxmox-restore-daemon/src/proxmox_restore_daemon/disk.rs
+++ b/proxmox-restore-daemon/src/proxmox_restore_daemon/disk.rs
@@ -17,7 +17,7 @@ use pbs_api_types::BLOCKDEVICE_NAME_REGEX;
 
 const_regex! {
     VIRTIO_PART_REGEX = r"^vd[a-z]+(\d+)$";
-    ZPOOL_POOL_NAME_REGEX = r"^ {3}pool: (.*)$";
+    ZPOOL_POOL_NAME_REGEX = r"^ {2,3}pool: (.*)$";
     ZPOOL_IMPORT_DISK_REGEX = r"^\t {2,4}(vd[a-z]+(?:\d+)?)\s+ONLINE$";
 }
 
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2025-06-02  9:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-02  9:47 [pve-devel] [PATCH proxmox-backup/proxmox-backup-restore-image] update and adapt to ZFS 2.3 and kernel 6.14 Stoiko Ivanov
2025-06-02  9:47 ` [pve-devel] [PATCH proxmox-backup-restore-image 1/5] build initramfs: usr-merge initramfs Stoiko Ivanov
2025-06-02  9:47 ` [pve-devel] [PATCH proxmox-backup-restore-image 2/5] update ZFS to 2.3.2 Stoiko Ivanov
2025-06-02  9:47 ` [pve-devel] [PATCH proxmox-backup-restore-image 3/5] build initramfs: remove additional ZFS scripts Stoiko Ivanov
2025-06-02  9:47 ` [pve-devel] [PATCH proxmox-backup-restore-image 4/5] update ubuntu-kernel to Ubuntu-6.14.0-22.22 Stoiko Ivanov
2025-06-02  9:47 ` [pve-devel] [PATCH proxmox-backup-restore-image 5/5] kernel: enable more filesystem options Stoiko Ivanov
2025-06-02  9:47 ` Stoiko Ivanov [this message]
2025-06-03  8:59 ` [pve-devel] applied: [pbs-devel] [PATCH proxmox-backup/proxmox-backup-restore-image] update and adapt to ZFS 2.3 and kernel 6.14 Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250602094756.519927-7-s.ivanov@proxmox.com \
    --to=s.ivanov@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal