From: "Michael Köppl" <m.koeppl@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server v7 2/4] fix #3711: make removal of VM possible if store does not exist anymore
Date: Tue, 27 May 2025 18:01:38 +0200 [thread overview]
Message-ID: <20250527160140.230174-9-m.koeppl@proxmox.com> (raw)
In-Reply-To: <20250527160140.230174-1-m.koeppl@proxmox.com>
Similar to the handling of storage errors in other parts of
destroy_vm(), an error during the call to PVE::Storage::path() should
not stop the VM from being destroyed. Instead, the user should be warned
and the function should continue.
Originally-by: Stefan Hrdlicka <s.hrdlicka@proxmox.com>
[ MK: log_warn if check fails instead of ignoring error ]
Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
PVE/QemuServer.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index c55617bd..c0170a38 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -2131,7 +2131,8 @@ sub destroy_vm {
return if !$volid || $volid =~ m|^/|;
return if $volids->{$volid};
- my ($path, $owner) = PVE::Storage::path($storecfg, $volid);
+ my ($path, $owner) = eval { PVE::Storage::path($storecfg, $volid) };
+ log_warn("failed to get path and owner of volume '$volid': $@") if $@;
return if !$path || !$owner || ($owner != $vmid);
$volids->{$volid} = 1;
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-05-27 16:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-27 16:01 [pve-devel] [PATCH container/qemu-server/storage v7 00/10] fix #3711 and adapt drive detach/remove behavior Michael Köppl
2025-05-27 16:01 ` [pve-devel] [PATCH storage v7 1/2] vdisk_free: print warning if underlying storage does not exist Michael Köppl
2025-05-27 16:01 ` [pve-devel] [PATCH storage v7 2/2] parse_volname: print warning if storage does not exists Michael Köppl
2025-05-27 16:01 ` [pve-devel] [PATCH container v7 1/4] fix #3711: warn about storage errors during mountpoint delete Michael Köppl
2025-05-27 16:01 ` [pve-devel] [PATCH container v7 2/4] destroy_lxc, delete_mp_volume: rename $volume to $volid Michael Köppl
2025-05-27 16:01 ` [pve-devel] [PATCH container v7 3/4] config: ensure valid volid through parse_volume Michael Köppl
2025-05-27 16:01 ` [pve-devel] [PATCH container v7 4/4] add linked clone check when destroying container template Michael Köppl
2025-05-27 16:01 ` [pve-devel] [PATCH qemu-server v7 1/4] adapt linked clone check to not die if an error occurs during check Michael Köppl
2025-05-27 16:01 ` Michael Köppl [this message]
2025-05-27 16:01 ` [pve-devel] [PATCH qemu-server v7 3/4] destroy_vm: use log_warn for vdisk_free errors for consistency Michael Köppl
2025-05-27 16:01 ` [pve-devel] [PATCH qemu-server v7 4/4] display warnings for storage errors or if storage no longer exists Michael Köppl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250527160140.230174-9-m.koeppl@proxmox.com \
--to=m.koeppl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox